fix(ci): improve release workflow#566
Conversation
d512b25 to
1b3c0fd
Compare
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
1b3c0fd to
11d4aee
Compare
1. Fix tag format - use existing format without 'v' prefix (1.0.5 not v1.0.5) 2. Fix bot email to use GitHub's format so app avatar shows on commits 3. Update README sections with full changelog content, not just version number Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
11d4aee to
8cb4f3e
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Code ReviewFound 2 issues related to sed command usage in the workflow. Issue 1: README.md sed command (line 334) The sed c command with literal newlines in NEW_SECTION will not work as intended. GNU sed interprets the first literal newline as the end of the replacement text, meaning only the first line will be used. Location: JEngine/.github/workflows/release.yml Lines 331 to 335 in 8cb4f3e The NEW_SECTION variable is constructed using bash newline syntax which creates actual newline characters. For multi-line replacements with sed c command, each line (except the last) must end with a backslash for line continuation. Suggested fix: Use a temp file approach with the r command instead of c command. Issue 2: README_zh_cn.md sed command (line 362) Same issue as above but for the Chinese README file. Location: JEngine/.github/workflows/release.yml Lines 359 to 363 in 8cb4f3e Suggested fix: Same temp file approach as Issue 1. |
Summary
Multiple fixes for the release workflow:
1. Fix tag format
v1.0.5to1.0.5(existing tags don't havevprefix)2. Fix bot email for avatar
{APP_ID}+jengine-release-bot[bot]@users.noreply.github.com3. Update README with full changelog
Changes
Test plan
🤖 Generated with Claude Code