fix(ci): move write permissions to job level for Scorecard compliance#581
Merged
Conversation
- pr-tests.yml: Set explicit permissions at workflow level, jobs restrict further - unity-tests.yml: Set explicit permissions for reusable workflow Using read-all at workflow level prevents jobs from getting write permissions. Instead, set maximum needed permissions at workflow level and let jobs restrict. Signed-off-by: JasonXuDeveloper <jasonxudeveloper@gmail.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
JasonXuDeveloper
force-pushed
the
fix/token-permissions
branch
from
09218e0 to
ea41344
Compare
Write permissions are required for: - checks: write - GameCI publishes test results as check runs - statuses: write - Setting commit status for branch protection - pull-requests: write - Commenting test results on PRs - contents: write - Release workflow creates tags and commits Signed-off-by: JasonXuDeveloper <jasonxudeveloper@gmail.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
- Remove unnecessary checkout step - Add -R flag to gh pr review command - Check for exact Claude message "No issues found. Checked for bugs and CLAUDE.md compliance" Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
JasonXuDeveloper
force-pushed
the
fix/token-permissions
branch
from
fc8202d to
4c0d119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read-allin pr-tests.yml and unity-tests.ymlThis addresses OpenSSF Scorecard Token-Permissions alerts by following the principle of least privilege.
Test plan
🤖 Generated with Claude Code