chore: add branch-protection annotation to scorecard config#582
Closed
JasonXuDeveloper wants to merge 2 commits into
Closed
chore: add branch-protection annotation to scorecard config#582JasonXuDeveloper wants to merge 2 commits into
JasonXuDeveloper wants to merge 2 commits into
Conversation
Using GitHub Rulesets instead of classic branch protection: - Rulesets require 1 approver and code owner review - last_push_approval disabled to allow auto-approve bot - bypass_actors: [] prevents admin bypass Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
Claude Code Action posts a comment with 'No issues found. Checked for bugs and CLAUDE.md compliance.' when review passes. Check for this comment instead of check run output fields which are not set. Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
JasonXuDeveloper
force-pushed
the
fix/branch-protection-annotation
branch
from
e0e7257 to
312e5c9
Compare
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Owner
Author
|
Closing to create a cleaner PR with just the auto-approve fix. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add annotation explaining why Branch-Protection score is not maximal:
last_push_approvaldisabled to allow auto-approve bot to workbypass_actors: []in rulesetsTest plan
🤖 Generated with Claude Code