-
Notifications
You must be signed in to change notification settings - Fork 345
refactor(core): extract MessageBox to separate UI package #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JasonXuDeveloper
merged 9 commits into
master
from
refactor/extract-messagebox-to-ui-package
Jan 28, 2026
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d9508df
refactor(core): extract MessageBox to separate UI package
JasonXuDeveloper 834cb50
fix(core): address PR review feedback for Prompt abstraction
JasonXuDeveloper c42c3fe
fix(core): remove redundant initialization and namespace
JasonXuDeveloper 0bcfa9c
fix(core): remove JEngine.Util reference from HotUpdate.Code
JasonXuDeveloper 8627fb9
chore(ui): update packages-lock.json for TextMeshPro dependency
JasonXuDeveloper 97ee140
chore(ui): set initial version to 0.0.0
JasonXuDeveloper 9682ac9
docs: add guidelines for creating new JEngine packages
JasonXuDeveloper 0dfaba8
docs: restructure CLAUDE.md into modular rules
JasonXuDeveloper d2fab2c
docs: add rule references and update copilot instructions
JasonXuDeveloper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // PromptInitializer.cs | ||
| // | ||
| // Author: | ||
| // JasonXuDeveloper <jason@xgamedev.net> | ||
| // | ||
| // Copyright (c) 2025 JEngine | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| // ============================================================================ | ||
| // IMPORTANT: This script requires the JEngine.UI package to be installed. | ||
| // | ||
| // To use this script: | ||
| // 1. Add the JEngine.UI package via OpenUPM: | ||
| // openupm add com.jasonxudeveloper.jengine.ui | ||
| // | ||
| // 2. Or add to your manifest.json: | ||
| // "com.jasonxudeveloper.jengine.ui": "1.0.0" | ||
| // | ||
| // If you don't need MessageBox dialogs, you can: | ||
| // - Delete this script entirely (Bootstrap will log warnings and continue) | ||
| // - Implement your own custom dialog provider by assigning to Prompt.ShowDialogAsync | ||
| // ============================================================================ | ||
|
|
||
| using JEngine.Core; | ||
| using JEngine.UI; | ||
| using UnityEngine; | ||
|
|
||
| /// <summary> | ||
| /// Initializes the Prompt system to use MessageBox for dialogs. | ||
| /// This runs automatically before any scene loads. | ||
| /// </summary> | ||
| public static class PromptInitializer | ||
|
JasonXuDeveloper marked this conversation as resolved.
|
||
| { | ||
| [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)] | ||
| private static void Initialize() | ||
| { | ||
| // Register MessageBox as the dialog provider for JEngine.Core | ||
| Prompt.ShowDialogAsync = MessageBox.Show; | ||
| Debug.Log("[JEngine] Prompt system initialized with MessageBox provider."); | ||
| } | ||
| } | ||
|
JasonXuDeveloper marked this conversation as resolved.
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
UnityProject/Packages/com.jasonxudeveloper.jengine.core/Runtime/Misc.meta
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
UnityProject/Packages/com.jasonxudeveloper.jengine.core/Runtime/Misc/MessageBox.cs.meta
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.