feat(util): add JAction parallel execution and improve test coverage#607
Merged
JasonXuDeveloper merged 5 commits intoJan 30, 2026
Merged
Conversation
github-actions
Bot
added
documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Add JActionExecutionContext for per-execution state isolation - Add JActionExecution result struct with per-execution Cancelled state - Add JActionExecutionHandle for per-execution cancellation control - Execute/ExecuteAsync now snapshot tasks enabling safe parallel execution - Switch from ValueTask to UniTask for better Unity integration - Add comprehensive tests for parallel execution, timeouts, and edge cases - Add MessageBox test hooks for pool state inspection - Update jaction skill documentation with new API and patterns Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
JasonXuDeveloper
force-pushed
the
feat/jaction-parallel-and-test-coverage
branch
from
4306e9f to
a0eb188
Compare
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
There was a problem hiding this comment.
Pull request overview
This PR adds parallel execution support to JAction with per-execution state isolation, switches from ValueTask to UniTask for better Unity integration, and significantly improves test coverage across JEngine.Util and JEngine.UI packages.
Changes:
- Introduces parallel execution mode with
JActionExecutionContextfor per-execution state isolation - Adds
JActionExecutionresult struct andJActionExecutionHandlefor fine-grained execution control - Switches async return types from
ValueTasktoUniTaskfor Unity-native async patterns - Adds comprehensive test coverage for parallel execution, object pooling, edge cases, and timeout scenarios
- Updates jaction skill documentation with new API patterns and parallel execution examples
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| JActionExecutionContext.cs | New internal class holding per-execution state for parallel execution support |
| JActionExecution.cs | New result struct capturing per-execution cancellation state |
| JActionExecutionHandle.cs | New awaitable handle with Cancel() for specific execution control |
| JAction.cs | Refactored to use execution contexts instead of instance-level state |
| JActionAwaitable.cs | Updated to work with execution contexts instead of JAction instances |
| JActionRunner.cs | Updated to process execution contexts instead of JAction instances |
| JEngine.Util.asmdef | Added UniTask dependency reference |
| JActionTests.cs | Added JObjectPool tests and improved edge case coverage |
| JActionRuntimeTests.cs | Added parallel execution, async function, and cancellation tests |
| MessageBox.cs | Added test hooks for pool state inspection (UNITY_INCLUDE_TESTS only) |
| MessageBoxTests.cs | Added comprehensive tests for button visibility, null handling, and concurrency |
| SKILL.md | Updated with parallel execution patterns, return types, and troubleshooting guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address CodeQL warnings about potential missed Dispose() calls by wrapping test code in try-finally blocks. Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
- Fix Task.CompletedTask -> UniTask.CompletedTask - Fix AsUniTask to delegate to awaiter (prevent double pool return) - Fix Reset to return execution contexts to pool before clearing - Fix MessageBox test hooks to use direct index access (avoid foreach) - Add comment explaining PlayerLoop single-threading in parallel test Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Convert try-finally patterns to 'using' declarations for cleaner resource management as suggested by CodeQL static analysis. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
JasonXuDeveloper
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HashSet does not support array indexing. Use LINQ First() method to get the first element from the collection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds parallel execution capabilities to JAction and improves test coverage for JEngine.Util and JEngine.UI packages.
Key Features
JAction Parallel Execution Mode
Parallel()method: Enable concurrent execution of the same JActionJActionExecutionHandle: Awaitable handle for per-execution control withCancel()methodJActionExecution: Result struct with per-executionCancelledstateExecuteAsync()don't affect running executionsNew Types
JActionExecutionContext: Internal per-execution state for concurrent execution isolationJActionExecution: Lightweight result struct returned when awaiting executionJActionExecutionHandle: Handle for controlling individual executionsTest Coverage Improvements
JEngine.Util
JEngine.UI
Plugin Documentation
Updated
.claude-plugin/skills/jaction/SKILL.mdwith:thisas stateTest plan
🤖 Generated with Claude Code