release v1.0.6

- [opt] delay memory allocation to prevent allocation when connection is failed

Author: JasonXuDeveloper

Miku.Core/NetClient.cs

@@ -53,29 +53,11 @@ public class NetClient
         private bool _isConnected;
         private int _sending;
 
-        private readonly SocketAsyncEventArgs _receiveArg;
-        private readonly SocketAsyncEventArgs _sendArg;
-        private readonly ArrayBufferWriter<byte> _receivedData;
+        private SocketAsyncEventArgs _receiveArg;
+        private SocketAsyncEventArgs _sendArg;
+        private ArrayBufferWriter<byte> _receivedData;
         private byte[] _tempSendBuffer;
 
-        /// <summary>
-        /// Create a new instance of NetClient
-        /// </summary>
-        /// <param name="bufferSize"></param>
-        public NetClient(int bufferSize = 1024)
-        {
-            _receivedData = new ArrayBufferWriter<byte>(bufferSize);
-
-            _receiveArg = new SocketAsyncEventArgs();
-            _receiveArg.SetBuffer(new byte[bufferSize], 0, bufferSize);
-            _receiveArg.UserToken = this;
-            _receiveArg.Completed += HandleReadWrite;
-
-            _sendArg = new SocketAsyncEventArgs();
-            _sendArg.UserToken = this;
-            _sendArg.Completed += HandleReadWrite;
-        }
-
         /// <summary>
         /// Add a middleware to the client
         /// </summary>
@@ -99,8 +81,9 @@ public void RemoveMiddleware(INetMiddleware middleware)
         /// </summary>
         /// <param name="ip"></param>
         /// <param name="port"></param>
+        /// <param name="bufferSize"></param>
         /// <exception cref="InvalidOperationException"></exception>
-        public void Connect(string ip, int port)
+        public void Connect(string ip, int port, int bufferSize = 1024)
         {
             if (_isConnected)
             {
@@ -112,6 +95,17 @@ public void Connect(string ip, int port)
             _isConnected = true;
             Ip = ((System.Net.IPEndPoint)_socket.RemoteEndPoint!).Address.ToString();
 
+            _receivedData = new ArrayBufferWriter<byte>(bufferSize);
+
+            _receiveArg = new SocketAsyncEventArgs();
+            _receiveArg.SetBuffer(new byte[bufferSize], 0, bufferSize);
+            _receiveArg.UserToken = this;
+            _receiveArg.Completed += HandleReadWrite;
+
+            _sendArg = new SocketAsyncEventArgs();
+            _sendArg.UserToken = this;
+            _sendArg.Completed += HandleReadWrite;
+
             OnConnected?.Invoke();
 
             if (!_socket.ReceiveAsync(_receiveArg))
@@ -124,8 +118,9 @@ public void Connect(string ip, int port)
         /// When a server accepts a connection, use this method to connect the client
         /// </summary>
         /// <param name="socket"></param>
+        /// <param name="bufferSize"></param>
         /// <exception cref="InvalidOperationException"></exception>
-        internal void Connect(Socket socket)
+        internal void Connect(Socket socket, int bufferSize = 1024)
         {
             if (_isConnected)
             {
@@ -135,6 +130,17 @@ internal void Connect(Socket socket)
             _socket = socket;
             _isConnected = true;
             Ip = ((System.Net.IPEndPoint)socket.RemoteEndPoint!).Address.ToString();
+            
+            _receivedData = new ArrayBufferWriter<byte>(bufferSize);
+
+            _receiveArg = new SocketAsyncEventArgs();
+            _receiveArg.SetBuffer(new byte[bufferSize], 0, bufferSize);
+            _receiveArg.UserToken = this;
+            _receiveArg.Completed += HandleReadWrite;
+
+            _sendArg = new SocketAsyncEventArgs();
+            _sendArg.UserToken = this;
+            _sendArg.Completed += HandleReadWrite;
 
             OnConnected?.Invoke();
 

Miku.Core/NetServer.cs

@@ -126,7 +126,7 @@ private void ProcessAccept(object sender, SocketAsyncEventArgs e)
                 Socket acceptedSocket = e.AcceptSocket;
 
                 // Create a new NetClient using the accepted socket.
-                NetClient client = new NetClient(BufferSize);
+                NetClient client = new NetClient();
                 lock (_clients)
                 {
                     _clients.Add(client);
@@ -143,7 +143,7 @@ private void ProcessAccept(object sender, SocketAsyncEventArgs e)
                 };
                 client.OnDataReceived += data => OnClientDataReceived?.Invoke(client, data);
                 client.OnError += OnError;
-                client.Connect(acceptedSocket);
+                client.Connect(acceptedSocket, BufferSize);
             }
             // If the accept operation was canceled, then the server is stopped.
             else if (e.SocketError != SocketError.Interrupted && e.SocketError != SocketError.OperationAborted)