Skip to content

Commit 6f85750

Browse files
committed
chore: Remove serde feature
This feature was added with good intentions of reducing compilation time for users that don't need it, but the project in the current state doesn't actually compile without this feature. So we remove it to reduce the complexity of the codebase.
1 parent 7f2a1f7 commit 6f85750

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

galileo/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ readme = "../README.md"
1212
exclude = ["examples"]
1313

1414
[features]
15-
default = ["wgpu", "serde", "winit", "_tests", "rustybuzz", "image", "reqwest-default-tls"]
15+
default = ["wgpu", "winit", "_tests", "rustybuzz", "image", "reqwest-default-tls"]
1616
wgpu = ["dep:wgpu", "raw-window-handle"]
1717
geojson = ["dep:geojson", "galileo-types/geojson"]
1818
rustybuzz = ["dep:rustybuzz"]
@@ -46,7 +46,7 @@ quick_cache = { workspace = true }
4646
raw-window-handle = { workspace = true, optional = true }
4747
regex = { workspace = true }
4848
rustybuzz = { workspace = true, optional = true }
49-
serde = { workspace = true, optional = true, features = ["std", "derive", "rc"] }
49+
serde = { workspace = true, features = ["std", "derive", "rc"] }
5050
serde_json = { workspace = true }
5151
strfmt = { workspace = true }
5252
thiserror = { workspace = true }

galileo/src/color.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
1-
#[cfg(feature = "serde")]
21
use serde::{Deserialize, Serialize};
32

43
/// Color representation.
5-
#[derive(Debug, Default, Copy, Clone, PartialEq, Eq)]
6-
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
7-
#[cfg_attr(feature = "serde", serde(from = "String", into = "String"))]
4+
#[derive(Debug, Default, Copy, Clone, PartialEq, Eq, Serialize, Deserialize)]
5+
#[serde(from = "String", into = "String")]
86
pub struct Color {
97
r: u8,
108
g: u8,

0 commit comments

Comments
 (0)