improve after review

Author: JavaSaBr

rlib-logger-api/src/main/java/javasabr/rlib/logger/api/Logger.java

@@ -431,42 +431,61 @@ default <A, B, C, D> void info(A arg1, B arg2, C arg3, D arg4, @NonNull N4Factor
   }
 
   /**
-   * Check of enabling the logger level.
+   * Checks whether logging is enabled at the specified level.
+   *
+   * @param level the log level
+   * @return true if logging is enabled, false otherwise
+   * @since 10.0.0
    */
   default boolean enabled(@NonNull LoggerLevel level) {
     return level.enabled();
   }
 
   /**
-   * Check of enabling the error level.
+   * Checks whether logging is enabled at the error level.
+   *
+   * @return true if logging is enabled, false otherwise
+   * @since 10.0.0
    */
   default boolean errorEnabled() {
     return enabled(LoggerLevel.ERROR);
   }
 
   /**
-   * Check of enabling the warning level.
+   * Checks whether logging is enabled at the warning level.
+   *
+   * @return true if logging is enabled, false otherwise
+   * @since 10.0.0
    */
   default boolean warnEnabled() {
     return enabled(LoggerLevel.WARNING);
   }
 
   /**
-   * Check of enabling the info level.
+   * Checks whether logging is enabled at the info level.
+   *
+   * @return true if logging is enabled, false otherwise
+   * @since 10.0.0
    */
   default boolean infoEnabled() {
     return enabled(LoggerLevel.INFO);
   }
 
   /**
-   * Check of enabling the debug level.
+   * Checks whether logging is enabled at the debug level.
+   *
+   * @return true if logging is enabled, false otherwise
+   * @since 10.0.0
    */
   default boolean debugEnabled() {
     return enabled(LoggerLevel.DEBUG);
   }
 
   /**
-   * Check of enabling the trace level.
+   * Checks whether logging is enabled at the trace level.
+   *
+   * @return true if logging is enabled, false otherwise
+   * @since 10.0.0
    */
   default boolean traceEnabled() {
     return enabled(LoggerLevel.TRACE);

rlib-logger-impl/src/main/java/javasabr/rlib/logger/impl/config/loader/LoggerConfigLoadersProvider.java

@@ -2,7 +2,18 @@
 
 import javasabr.rlib.collections.array.Array;
 
+/**
+ * Provider of additional logger configuration loaders.
+ *
+ * @since 10.0.0
+ */
 public interface LoggerConfigLoadersProvider {
 
+  /**
+   * Returns additional logger configuration loaders.
+   *
+   * @return the logger configuration loaders
+   * @since 10.0.0
+   */
   Array<LoggerConfigLoader> getLoggerConfigLoaders();
 }

rlib-logger-impl/src/main/java/javasabr/rlib/logger/impl/config/render/impl/pattern/PatternRenderNodesParser.java

@@ -64,7 +64,7 @@ private static ParsedNode parse(String nodeName, String pattern, int afterNameIn
   }
 
   private static String extractArgumentsString(String pattern, int afterNameIndex) {
-    if (pattern.charAt(afterNameIndex) != '{') {
+    if (pattern.length() <= afterNameIndex || pattern.charAt(afterNameIndex) != '{') {
       throw new IllegalArgumentException("Missed '{' at position:[%d] in pattern:[%s]"
           .formatted(afterNameIndex, pattern));
     }

rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/config/render/impl/pattern/node/DateTimePatternRenderNodeTest.java

@@ -0,0 +1,23 @@
+package javasabr.rlib.logger.impl.config.render.impl.pattern.node;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import javasabr.rlib.logger.api.LoggerLevel;
+import org.junit.jupiter.api.Test;
+
+class DateTimePatternRenderNodeTest {
+
+  @Test
+  void shouldAppendCurrentDateTimeUsingProvidedPattern() {
+    // given:
+    var node = new DateTimePatternRenderNode("yyyy-MM-dd HH:mm:ss");
+    var buffer = new StringBuilder("prefix:");
+
+    // when:
+    node.append(LoggerLevel.INFO, PatternRenderNodeTestUtils.LOGGER, "ignored-message", buffer);
+
+    // then:
+    assertThat(buffer.toString())
+        .matches("prefix:\\d{4}-\\d{2}-\\d{2} \\d{2}:\\d{2}:\\d{2}");
+  }
+}

rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/config/render/impl/pattern/node/LevelPatternRenderNodeTest.java

@@ -0,0 +1,23 @@
+package javasabr.rlib.logger.impl.config.render.impl.pattern.node;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import javasabr.rlib.logger.api.LoggerLevel;
+import org.junit.jupiter.api.Test;
+
+class LevelPatternRenderNodeTest {
+
+  @Test
+  void shouldAppendLevelTitleWithOffset() {
+    // given:
+    var node = new LevelPatternRenderNode();
+    var buffer = new StringBuilder("prefix:");
+
+    // when:
+    node.append(LoggerLevel.WARNING, PatternRenderNodeTestUtils.LOGGER, "ignored-message", buffer);
+
+    // then:
+    assertThat(buffer.toString())
+        .isEqualTo("prefix:WARN  ");
+  }
+}

rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/config/render/impl/pattern/node/MessagePatternRenderNodeTest.java

@@ -0,0 +1,23 @@
+package javasabr.rlib.logger.impl.config.render.impl.pattern.node;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import javasabr.rlib.logger.api.LoggerLevel;
+import org.junit.jupiter.api.Test;
+
+class MessagePatternRenderNodeTest {
+
+  @Test
+  void shouldAppendMessageToBuffer() {
+    // given:
+    var node = new MessagePatternRenderNode();
+    var buffer = new StringBuilder("prefix:");
+
+    // when:
+    node.append(LoggerLevel.ERROR, PatternRenderNodeTestUtils.LOGGER, "actual-message", buffer);
+
+    // then:
+    assertThat(buffer.toString())
+        .isEqualTo("prefix:actual-message");
+  }
+}

rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/config/render/impl/pattern/node/PatternRenderNodeTestUtils.java

@@ -0,0 +1,30 @@
+package javasabr.rlib.logger.impl.config.render.impl.pattern.node;
+
+import javasabr.rlib.logger.api.Logger;
+import javasabr.rlib.logger.api.LoggerLevel;
+
+final class PatternRenderNodeTestUtils {
+
+  static final Logger LOGGER = new Logger() {
+    @Override
+    public String name() {
+      return "example.logger.PatternRenderNodeTest";
+    }
+
+    @Override
+    public String shortName() {
+      return "PatternRenderNodeTest";
+    }
+
+    @Override
+    public void print(LoggerLevel level, String message) {}
+
+    @Override
+    public void print(LoggerLevel level, Throwable exception) {}
+
+    @Override
+    public void print(LoggerLevel level, String message, Throwable exception) {}
+  };
+
+  private PatternRenderNodeTestUtils() {}
+}

rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/config/render/impl/pattern/node/ShortLoggerPatternRenderNodeTest.java

@@ -0,0 +1,23 @@
+package javasabr.rlib.logger.impl.config.render.impl.pattern.node;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import javasabr.rlib.logger.api.LoggerLevel;
+import org.junit.jupiter.api.Test;
+
+class ShortLoggerPatternRenderNodeTest {
+
+  @Test
+  void shouldAppendLoggerShortNameToBuffer() {
+    // given:
+    var node = new ShortLoggerPatternRenderNode();
+    var buffer = new StringBuilder("prefix:");
+
+    // when:
+    node.append(LoggerLevel.INFO, PatternRenderNodeTestUtils.LOGGER, "ignored-message", buffer);
+
+    // then:
+    assertThat(buffer.toString())
+        .isEqualTo("prefix:PatternRenderNodeTest");
+  }
+}

rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/config/render/impl/pattern/node/StringPatternRenderNodeTest.java

@@ -0,0 +1,23 @@
+package javasabr.rlib.logger.impl.config.render.impl.pattern.node;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import javasabr.rlib.logger.api.LoggerLevel;
+import org.junit.jupiter.api.Test;
+
+class StringPatternRenderNodeTest {
+
+  @Test
+  void shouldAppendConfiguredStringToBuffer() {
+    // given:
+    var node = new StringPatternRenderNode("configured-value");
+    var buffer = new StringBuilder("prefix:");
+
+    // when:
+    node.append(LoggerLevel.DEBUG, PatternRenderNodeTestUtils.LOGGER, "ignored-message", buffer);
+
+    // then:
+    assertThat(buffer.toString())
+        .isEqualTo("prefix:configured-value");
+  }
+}