Update API part 3#68
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the project version to 10.0.alpha15, updates GitHub Actions versions, and introduces a paginated values(container, startIndex, limit) API on Dictionary with implementations for the three hash-based dictionaries. Also refactors ThreadUtils to use Lombok's @CustomLog and changes sleep(long) to return a boolean indicating interruption.
Changes:
- Add a partitioned
values(...)accessor toDictionaryand implement it in all threeAbstractHashBased*Dictionaryclasses, with matching parameterized tests; also add a sharedtoString()to the int/long variants. - Change
ThreadUtils.sleepto returnboolean(interrupted flag) and switch logger to Lombok@CustomLog. - Bump version to
10.0.alpha15and upgradeactions/checkout,actions/setup-java, andgradle/actions/*in the develop workflow.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rlib-collections/.../Dictionary.java | Adds new paginated values(container, startIndex, limit) API |
| rlib-collections/.../impl/AbstractHashBasedRefToRefDictionary.java | Implements paginated values; minor toString whitespace cleanup |
| rlib-collections/.../impl/AbstractHashBasedLongToRefDictionary.java | Implements paginated values; adds toString |
| rlib-collections/.../impl/AbstractHashBasedIntToRefDictionary.java | Implements paginated values; adds toString |
| rlib-collections/.../MutableRefToRefDictionaryTest.java | Adds test for paginated values iteration |
| rlib-collections/.../MutableLongToRefDictionaryTest.java | Adds test for paginated values iteration |
| rlib-collections/.../MutableIntToRefDictionaryTest.java | Adds test for paginated values iteration |
| rlib-collections/.../RefToRefDictionaryTest.java | Whitespace-only change |
| rlib-common/.../ThreadUtils.java | Switches to @CustomLog; sleep now returns boolean |
| build.gradle | Version bump to 10.0.alpha15 |
| README.md | Doc version bump to 10.0.alpha15 |
| .github/workflows/develop.yml | Upgrades third-party action versions |
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Summary
1. Logger API expansion and migration path
Logger.N2IntFactory<A, B>for(A, B, int)message compositionwarn(...)overloads mirroring existingwarning(...)API, including message, throwable, and typed factory overloadsprint(...)overload forN2IntFactoryand correspondingdebug(...)/warn(...)usage pathwarning(...)overloads as deprecated forward-compatible aliases2. Collections and dictionary updates
Dictionary.values(MutableArray<V> container, int startIndex, int limit)ArrayCollectors,DictionaryCollectors) and related collection internals3. Operating system detection and common utilities
OperatingSystemrecordOperatingSystemResolverto return resolvedOperatingSystemdirectly with updated Linux/macOS/Darwin detection flowUtils,ThreadUtils,ClassUtils,ObjectUtils,StringUtils) and aligned logger usage with new warning API4. Cross-module refactoring and cleanup
README.md,.github/workflows/develop.yml).github/skills/branch-review.mdTesting & Validation
./gradlew clean build:rlib-logger-api:build,:rlib-collections:build,:rlib-common:build)