fix: Fix the edge case in collection values from Dictionary#69
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily addresses a dictionary values extraction edge case in the collections module, while also updating logger level padding/tests and bumping the project version.
Changes:
- Adjusted
LinkedEntryUtils.values(...)capacity reservation for partial value extraction. - Expanded
MutableRefToRefDictionaryTestcoverage for denser dictionary values iteration. - Updated logger level formatting expectations and bumped version references to
10.0.alpha16.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
rlib-collections/src/main/java/javasabr/rlib/collections/dictionary/impl/util/LinkedEntryUtils.java |
Updates partial values collection reservation behavior. |
rlib-collections/src/test/java/javasabr/rlib/collections/dictionary/MutableRefToRefDictionaryTest.java |
Increases test data density for partial values iteration. |
rlib-collections/src/main/java/javasabr/rlib/collections/array/impl/AbstractMutableArray.java |
Whitespace-only cleanup. |
rlib-logger-api/src/main/java/javasabr/rlib/logger/api/LoggerLevel.java |
Changes log level padding offsets. |
rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/DefaultLoggerTest.java |
Updates logger tests and listener setup/cleanup. |
README.md |
Updates documented RLib version. |
build.gradle |
Updates root project version. |
Comments suppressed due to low confidence (1)
rlib-logger-impl/src/test/java/javasabr/rlib/logger/impl/DefaultLoggerTest.java:54
- These overrides mutate the cached logger returned by LoggerManager, but cleanup only removes the listener and clears captured logs. Because LoggerManager/DefaultLoggerService keeps loggers in a static service cache, DEBUG/INFO/etc. stay enabled for DefaultLoggerTest after this test, which can leak global logger configuration into later tests in the same JVM. Reset the overridden levels in cleanup or avoid mutating the shared logger state.
logger.overrideEnabled(LoggerLevel.DEBUG, true);
logger.overrideEnabled(LoggerLevel.WARNING, true);
logger.overrideEnabled(LoggerLevel.ERROR, true);
logger.overrideEnabled(LoggerLevel.INFO, true);
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR primarily addresses a dictionary values extraction edge case in the collections module, while also updating logger level padding/tests and bumping the project version.
Changes:
LinkedEntryUtils.values(...)capacity reservation for partial value extraction.MutableRefToRefDictionaryTestcoverage for denser dictionary values iteration.10.0.alpha16.