perf: Refactor the code to use interning and deduplication to reduce CPU usage by over 300%

Added two interners: one slotmap with a hashmap for deduplication, and a
trie-based string interner that prevent large moves of stuff like
`Issue`s and the duplication of frequent structs like `Author`. Each
component now has a `Arc<RwLock<UiIssuePool>>`, which is used to add and
query issues from the global interning system. Runtime performance and
snappiness seem equivalent to previous versions

refactor perf: changed IssueList's IssueListItem to store a IssueId

refactor: remove n_links field from interner

fix: remove the issue about duplication in UiIssuePool

Author: JayanAXHF

Cargo.lock

@@ -53,6 +53,7 @@ cli-clipboard = "0.4.0"
 tachyonfx = { version = "0.24.0", default-features = false, features = ["std", "std-duration"] }
 serde = { version = "1.0.228", features = ["derive"] }
 serde_json = "1.0.149"
+slotmap = "1.0.7"
 
 [profile.release]
 codegen-units = 1 # Allows compiler to perform better optimization.

Cargo.toml

@@ -26,7 +26,7 @@ use ratatui::{
 use ratatui_macros::{horizontal, line, span, vertical};
 use std::{
     collections::{HashMap, HashSet},
-    sync::{Arc, OnceLock},
+    sync::{Arc, OnceLock, RwLock},
 };
 use syntect::{
     easy::HighlightLines,
@@ -47,6 +47,7 @@ use crate::{
             help::HelpElementKind,
             issue_list::{IssueClosePopupState, MainScreen, render_issue_close_popup},
         },
+        issue_data::{UiIssue, UiIssuePool},
         layout::Layout,
         toast_action,
         utils::get_border_style,
@@ -115,6 +116,19 @@ impl IssueConversationSeed {
             title: Some(Arc::<str>::from(issue.title.as_str())),
         }
     }
+
+    pub fn from_ui_issue(issue: &UiIssue, pool: &UiIssuePool) -> Self {
+        Self {
+            number: issue.number,
+            author: Arc::<str>::from(pool.author_login(issue.author)),
+            created_at: Arc::<str>::from(pool.resolve_str(issue.created_at_short)),
+            created_ts: issue.created_ts,
+            body: issue
+                .body
+                .map(|body| Arc::<str>::from(pool.resolve_str(body))),
+            title: Some(Arc::<str>::from(pool.resolve_str(issue.title))),
+        }
+    }
 }
 
 #[derive(Debug, Clone)]
@@ -217,6 +231,7 @@ pub struct IssueConversation {
     owner: String,
     repo: String,
     current_user: String,
+    issue_pool: Arc<RwLock<UiIssuePool>>,
     list_state: ListState<RowSelection>,
     message_keys: Vec<MessageKey>,
     show_timeline: bool,
@@ -293,7 +308,7 @@ impl IssueConversation {
         )
     }
 
-    pub fn new(app_state: crate::ui::AppState) -> Self {
+    pub fn new(app_state: crate::ui::AppState, issue_pool: Arc<RwLock<UiIssuePool>>) -> Self {
         Self {
             title: None,
             action_tx: None,
@@ -318,6 +333,7 @@ impl IssueConversation {
             owner: app_state.owner,
             repo: app_state.repo,
             current_user: app_state.current_user,
+            issue_pool,
             list_state: ListState::default(),
             message_keys: Vec::new(),
             show_timeline: false,
@@ -869,6 +885,7 @@ impl IssueConversation {
         };
         let owner = self.owner.clone();
         let repo = self.repo.clone();
+        let issue_pool = self.issue_pool.clone();
         tokio::spawn(async move {
             let Some(client) = GITHUB_CLIENT.get() else {
                 let _ = action_tx
@@ -888,11 +905,12 @@ impl IssueConversation {
                 .await
             {
                 Ok(issue) => {
-                    let _ = action_tx
-                        .send(Action::IssueCloseSuccess {
-                            issue: Box::new(issue),
-                        })
-                        .await;
+                    let issue_id = {
+                        let mut pool = issue_pool.write().expect("issue pool lock poisoned");
+                        let compact = UiIssue::from_octocrab(&issue, &mut pool);
+                        pool.upsert_issue(compact)
+                    };
+                    let _ = action_tx.send(Action::IssueCloseSuccess { issue_id }).await;
                 }
                 Err(err) => {
                     let _ = action_tx
@@ -1868,22 +1886,27 @@ impl Component for IssueConversation {
                     self.markdown_cache.remove(&existing.id);
                 }
             }
-            Action::IssueCloseSuccess { issue } => {
-                let issue = *issue;
+            Action::IssueCloseSuccess { issue_id } => {
+                let (issue_number, preview_seed) = {
+                    let pool = self.issue_pool.read().expect("issue pool lock poisoned");
+                    let issue = pool.get_issue(issue_id);
+                    (
+                        issue.number,
+                        crate::ui::components::issue_detail::IssuePreviewSeed::from_ui_issue(
+                            issue, &pool,
+                        ),
+                    )
+                };
                 let initiated_here = self
                     .close_popup
                     .as_ref()
-                    .is_some_and(|popup| popup.issue_number == issue.number);
+                    .is_some_and(|popup| popup.issue_number == issue_number);
                 if initiated_here {
                     self.close_popup = None;
                     self.close_error = None;
                     if let Some(action_tx) = self.action_tx.as_ref() {
                         let _ = action_tx
-                            .send(Action::SelectedIssuePreview {
-                                seed: crate::ui::components::issue_detail::IssuePreviewSeed::from_issue(
-                                    &issue,
-                                ),
-                            })
+                            .send(Action::SelectedIssuePreview { seed: preview_seed })
                             .await;
                         let _ = action_tx.send(Action::RefreshIssueList).await;
                     }

src/ui/components/issue_conversation.rs

@@ -1,6 +1,5 @@
 use async_trait::async_trait;
 use crossterm::event;
-use octocrab::models::issues::Issue;
 use rat_cursor::HasScreenCursor;
 use rat_widget::{
     event::{HandleEvent, TextOutcome, ct_event},
@@ -30,13 +29,15 @@ use crate::{
             issue_detail::IssuePreviewSeed,
             issue_list::MainScreen,
         },
+        issue_data::{IssueId, UiIssue, UiIssuePool},
         layout::Layout,
         toast_action,
         utils::get_border_style,
     },
 };
 use anyhow::anyhow;
 use ratatui_toaster::ToastType;
+use std::sync::{Arc, RwLock};
 
 pub const HELP: &[HelpElementKind] = &[
     crate::help_text!("Issue Create Help"),
@@ -67,6 +68,7 @@ pub struct IssueCreate {
     action_tx: Option<tokio::sync::mpsc::Sender<Action>>,
     owner: String,
     repo: String,
+    issue_pool: Arc<RwLock<UiIssuePool>>,
     screen: MainScreen,
     focus: FocusFlag,
     area: Rect,
@@ -86,11 +88,15 @@ pub struct IssueCreate {
 }
 
 impl IssueCreate {
-    pub fn new(AppState { owner, repo, .. }: AppState) -> Self {
+    pub fn new(
+        AppState { owner, repo, .. }: AppState,
+        issue_pool: Arc<RwLock<UiIssuePool>>,
+    ) -> Self {
         Self {
             action_tx: None,
             owner,
             repo,
+            issue_pool,
             screen: MainScreen::List,
             focus: FocusFlag::new().with_name("issue_create"),
             area: Rect::default(),
@@ -171,6 +177,7 @@ impl IssueCreate {
         };
         let owner = self.owner.clone();
         let repo = self.repo.clone();
+        let issue_pool = self.issue_pool.clone();
         self.creating = true;
         self.error = None;
 
@@ -197,10 +204,13 @@ impl IssueCreate {
 
             match create.send().await {
                 Ok(issue) => {
+                    let issue_id = {
+                        let mut pool = issue_pool.write().expect("issue pool lock poisoned");
+                        let compact = UiIssue::from_octocrab(&issue, &mut pool);
+                        pool.upsert_issue(compact)
+                    };
                     let _ = action_tx
-                        .send(Action::IssueCreateSuccess {
-                            issue: Box::new(issue),
-                        })
+                        .send(Action::IssueCreateSuccess { issue_id })
                         .await;
                     let _ = action_tx
                         .send(toast_action(
@@ -223,16 +233,22 @@ impl IssueCreate {
         });
     }
 
-    async fn handle_create_success(&mut self, issue: Issue) {
+    async fn handle_create_success(&mut self, issue_id: IssueId) {
         self.creating = false;
         self.error = None;
         let Some(action_tx) = self.action_tx.clone() else {
             return;
         };
-        let number = issue.number;
-        let labels = issue.labels.clone();
-        let preview_seed = IssuePreviewSeed::from_issue(&issue);
-        let conversation_seed = IssueConversationSeed::from_issue(&issue);
+        let (number, labels, preview_seed, conversation_seed) = {
+            let pool = self.issue_pool.read().expect("issue pool lock poisoned");
+            let issue = pool.get_issue(issue_id);
+            (
+                issue.number,
+                issue.labels.clone(),
+                IssuePreviewSeed::from_ui_issue(issue, &pool),
+                IssueConversationSeed::from_ui_issue(issue, &pool),
+            )
+        };
         self.reset_form();
         let _ = action_tx
             .send(Action::SelectedIssue { number, labels })
@@ -440,9 +456,9 @@ impl Component for IssueCreate {
                 self.screen = MainScreen::CreateIssue;
                 self.reset_form();
             }
-            Action::IssueCreateSuccess { issue } => {
+            Action::IssueCreateSuccess { issue_id } => {
                 if self.screen == MainScreen::CreateIssue {
-                    self.handle_create_success(*issue).await;
+                    self.handle_create_success(issue_id).await;
                 }
             }
             Action::IssueCreateError { message } => {

src/ui/components/issue_create.rs

@@ -14,7 +14,12 @@ use ratatui_macros::line;
 
 use crate::{
     errors::AppError,
-    ui::{Action, AppState, components::DumbComponent, layout::Layout},
+    ui::{
+        Action, AppState,
+        components::DumbComponent,
+        issue_data::{UiIssue, UiIssuePool},
+        layout::Layout,
+    },
 };
 use hyperrat::Link;
 
@@ -59,6 +64,31 @@ impl IssuePreviewSeed {
                 .map(|pr| Arc::<str>::from(pr.html_url.as_str())),
         }
     }
+
+    pub fn from_ui_issue(issue: &UiIssue, pool: &UiIssuePool) -> Self {
+        let assignees = issue
+            .assignees
+            .iter()
+            .map(|assignee| Arc::<str>::from(pool.author_login(*assignee)))
+            .collect();
+        let milestone = issue
+            .milestone
+            .map(|milestone| Arc::<str>::from(pool.resolve_str(milestone)));
+        Self {
+            number: issue.number,
+            state: issue.state.clone(),
+            author: Arc::<str>::from(pool.author_login(issue.author)),
+            created_at: Arc::<str>::from(pool.resolve_str(issue.created_at_short)),
+            updated_at: Arc::<str>::from(pool.resolve_str(issue.updated_at_short)),
+            comments: issue.comments,
+            assignees,
+            milestone,
+            is_pull_request: issue.is_pull_request,
+            pull_request_url: issue
+                .pull_request_url
+                .map(|url| Arc::<str>::from(pool.resolve_str(url))),
+        }
+    }
 }
 
 #[derive(Debug, Clone)]