Skip to content

Commit 92d9b65

Browse files
committed
fix: change keyring to use persistent secret service on linux
1 parent 8d9b6ba commit 92d9b65

3 files changed

Lines changed: 63 additions & 6 deletions

File tree

Cargo.lock

Lines changed: 54 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ keywords = ["tui", "cli", "github", "prodcutivity", "ratatui"]
1313
categories = ["command-line-utilities", "command-line-interface"]
1414

1515
[workspace]
16-
members = [
17-
"crates/hyperrat"
18-
,
19-
"crates/ratatui-toaster"
20-
]
16+
members = ["crates/hyperrat", "crates/ratatui-toaster"]
17+
18+
[features]
19+
default = ["keyring/linux-native"]
20+
persist-token = ["keyring/sync-secret-service"]
2121

2222
[dependencies]
2323
anyhow = "1.0"
@@ -30,7 +30,7 @@ edit = "0.1.5"
3030
futures = "0.3.31"
3131
hyperrat = { path = "crates/hyperrat", version = "0.1.1" }
3232
inquire = "0.9.3"
33-
keyring = { version = "3.6.3", features = ["apple-native", "windows-native", "linux-native"] }
33+
keyring = { version = "3.6.3", features = ["apple-native", "windows-native"] }
3434
octocrab = "0.49.5"
3535
pulldown-cmark = "0.13.0"
3636
regex = "1.11.1"

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ See [KEYBINDINGS.md](./KEYBINDS.md) for a list of keybindings used in the applic
9999

100100
### Token Security
101101

102+
> [!NOTE]
103+
> To persist the token across reboots (i.e. to store it on disk) on Linux, build with the `persist-token` feature flag. This requires for `dbus` to be present and `DBUS_SESSION_BUS_ADDRESS` to be set.
104+
102105
`gitv` uses the `keyring` crate to securely store your GitHub token in your system's credential store. This means that your token is encrypted and protected by your operating system's security features, providing a secure way to manage your authentication credentials.
103106

104107
### Contributing

0 commit comments

Comments
 (0)