Skip to content

Commit ba6bfa7

Browse files
JayanAXHFJayanAXHF
committed
chore: fix clippy lints
1 parent a318b56 commit ba6bfa7

5 files changed

Lines changed: 56 additions & 79 deletions

File tree

‎src/ui/components/issue_conversation.rs‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1995,17 +1995,14 @@ impl Component for IssueConversation {
19951995
number,
19961996
reactions,
19971997
own_reactions,
1998-
} => {
1999-
if self
2000-
.current
2001-
.as_ref()
2002-
.is_some_and(|seed| seed.number == number)
2003-
{
2004-
self.reaction_error = None;
2005-
self.body_reaction_number = Some(number);
2006-
self.body_reactions = Some(reactions);
2007-
self.body_my_reactions = Some(own_reactions);
2008-
}
1998+
} if self
1999+
.current
2000+
.as_ref()
2001+
.is_some_and(|seed| seed.number == number) => {
2002+
self.reaction_error = None;
2003+
self.body_reaction_number = Some(number);
2004+
self.body_reactions = Some(reactions);
2005+
self.body_my_reactions = Some(own_reactions);
20092006
}
20102007
Action::IssueReactionEditError {
20112008
comment_id: _,

‎src/ui/components/issue_create.rs‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -473,19 +473,15 @@ impl Component for IssueCreate {
473473
}
474474
}
475475
}
476-
Action::Tick => {
477-
if self.creating {
478-
self.create_throbber_state.calc_next();
479-
}
476+
Action::Tick if self.creating => {
477+
self.create_throbber_state.calc_next();
480478
}
481479
Action::EnterIssueCreate => {
482480
self.screen = MainScreen::CreateIssue;
483481
self.reset_form();
484482
}
485-
Action::IssueCreateSuccess { issue_id } => {
486-
if self.screen == MainScreen::CreateIssue {
487-
self.handle_create_success(issue_id).await;
488-
}
483+
Action::IssueCreateSuccess { issue_id } if self.screen == MainScreen::CreateIssue => {
484+
self.handle_create_success(issue_id).await;
489485
}
490486
Action::IssueCreateError { message } => {
491487
self.creating = false;

‎src/ui/components/label_list.rs‎

Lines changed: 30 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -934,26 +934,20 @@ impl Component for LabelList {
934934
&& self.popup_search.is_none()
935935
{
936936
match key.code {
937-
crossterm::event::KeyCode::Char('a') => {
938-
if self.state.is_focused() {
939-
self.state.focus.set(false);
940-
let input = TextInputState::new_focused();
941-
next_mode = Some(LabelEditMode::Adding { input });
942-
handled = true;
943-
}
937+
crossterm::event::KeyCode::Char('a') if self.state.is_focused() => {
938+
self.state.focus.set(false);
939+
let input = TextInputState::new_focused();
940+
next_mode = Some(LabelEditMode::Adding { input });
941+
handled = true;
944942
}
945-
crossterm::event::KeyCode::Char('d') => {
946-
if self.state.is_focused() {
947-
self.handle_remove_selected().await;
948-
handled = true;
949-
}
943+
crossterm::event::KeyCode::Char('d') if self.state.is_focused() => {
944+
self.handle_remove_selected().await;
945+
handled = true;
950946
}
951-
crossterm::event::KeyCode::Char('f') => {
952-
if self.state.is_focused() {
953-
self.state.focus.set(false);
954-
self.open_popup_search();
955-
handled = true;
956-
}
947+
crossterm::event::KeyCode::Char('f') if self.state.is_focused() => {
948+
self.state.focus.set(false);
949+
self.open_popup_search();
950+
handled = true;
957951
}
958952
_ => {}
959953
}
@@ -1105,24 +1099,24 @@ impl Component for LabelList {
11051099
self.set_mode(LabelEditMode::Idle);
11061100
self.close_popup_search();
11071101
}
1108-
Action::IssueLabelsUpdated { number, labels } => {
1109-
if Some(number) == self.current_issue_number {
1110-
let prev = self
1111-
.state
1112-
.selected_checked()
1113-
.and_then(|idx| self.labels.get(idx).map(|label| label.name.clone()));
1114-
self.labels = labels
1115-
.into_iter()
1116-
.map(Into::<LabelListItem>::into)
1117-
.collect();
1118-
self.reset_selection(prev);
1119-
let status = self
1120-
.pending_status
1121-
.take()
1122-
.unwrap_or_else(|| "Labels updated.".to_string());
1123-
self.set_status(status);
1124-
self.set_mode(LabelEditMode::Idle);
1125-
}
1102+
Action::IssueLabelsUpdated { number, labels }
1103+
if Some(number) == self.current_issue_number =>
1104+
{
1105+
let prev = self
1106+
.state
1107+
.selected_checked()
1108+
.and_then(|idx| self.labels.get(idx).map(|label| label.name.clone()));
1109+
self.labels = labels
1110+
.into_iter()
1111+
.map(Into::<LabelListItem>::into)
1112+
.collect();
1113+
self.reset_selection(prev);
1114+
let status = self
1115+
.pending_status
1116+
.take()
1117+
.unwrap_or_else(|| "Labels updated.".to_string());
1118+
self.set_status(status);
1119+
self.set_mode(LabelEditMode::Idle);
11261120
}
11271121
Action::LabelSearchPageAppend {
11281122
request_id,

‎src/ui/components/search_bar.rs‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,8 @@ impl Component for TextSearch {
245245
Action::FinishedLoading => {
246246
self.state = State::Loaded;
247247
}
248-
Action::Tick => {
249-
if self.state == State::Loading {
250-
self.loader_state.calc_next();
251-
}
248+
Action::Tick if self.state == State::Loading => {
249+
self.loader_state.calc_next();
252250
}
253251
_ => {}
254252
}

‎src/ui/widgets/color_picker.rs‎

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -81,29 +81,21 @@ impl HandleEvent<Event, Regular, Outcome> for ColorPickerState {
8181
return Outcome::Continue;
8282
};
8383
match key.code {
84-
KeyCode::Up => {
85-
if self.row > 0 {
86-
self.row -= 1;
87-
return Outcome::Changed;
88-
}
84+
KeyCode::Up if self.row > 0 => {
85+
self.row -= 1;
86+
return Outcome::Changed;
8987
}
90-
KeyCode::Down => {
91-
if self.row + 1 < HUES.len() {
92-
self.row += 1;
93-
return Outcome::Changed;
94-
}
88+
KeyCode::Down if self.row + 1 < HUES.len() => {
89+
self.row += 1;
90+
return Outcome::Changed;
9591
}
96-
KeyCode::Left => {
97-
if self.col > 0 {
98-
self.col -= 1;
99-
return Outcome::Changed;
100-
}
92+
KeyCode::Left if self.col > 0 => {
93+
self.col -= 1;
94+
return Outcome::Changed;
10195
}
102-
KeyCode::Right => {
103-
if self.col + 1 < HUES[0].1.len() {
104-
self.col += 1;
105-
return Outcome::Changed;
106-
}
96+
KeyCode::Right if self.col + 1 < HUES[0].1.len() => {
97+
self.col += 1;
98+
return Outcome::Changed;
10799
}
108100
_ => {}
109101
}

0 commit comments

Comments
 (0)