Rollup of 3 PRs

[JayanAXHF]

closes #151
closes #152
closes #153

[greptile-apps]

Greptile Summary

This rollup combines three PRs: a hyperrat crate update migrating from the deprecated set_skip(bool) API to set_diff_option(CellDiffOption), an external-editor refactor that centralises editor lifecycle management in the top-level App instead of a fire-and-forget tokio::spawn, and a CI/infra pass that adds a Nix flake check workflow, installs native deps (libdbus-1-dev) in the bench jobs, and bumps actions/checkout to v7 across all workflows.

• hyperrat/src/lib.rs: Replaces set_skip/cell.skip with set_diff_option(CellDiffOption); also changes the placeholder symbol stored in skip cells from \" \" to \"s\". Two tests were updated but contain incorrect assertions (see inline comments).
• issue_conversation.rs: Removes the inline editor task that called ratatui::restore/ratatui::init directly; instead sends Action::OpenExternalEditor so the App manages the full terminal teardown/setup cycle.
• CI workflows: Nix flake CI added; bench jobs now explicitly install native dependencies; actions/checkout standardised to v7.

Important Files Changed

Filename	Overview
crates/hyperrat/src/lib.rs	Migrates skip-cell API from set_skip(bool) to set_diff_option(CellDiffOption), but two test assertions were incorrectly updated: the tail-cell assertion was logically inverted and the skip-cell symbol expectation still says " " while the code now stores "s".
src/ui/components/issue_conversation.rs	Moves external-editor session management out of the component and into the top-level App via an OpenExternalEditor action, removing the inline tokio::spawn that called ratatui::restore and ratatui::init directly. Clean refactor.
.github/workflows/bench.yml	Bumps actions/checkout to v7 and adds an explicit Install native deps step (pkg-config, libdbus-1-dev) before running benchmarks.
.github/workflows/nix.yml	New workflow that installs Nix and runs nix flake check on push and PRs. Functional, but has trailing whitespace on the steps: line.
.github/workflows/build.yml	Bumps actions/checkout from v6 to v7; no other changes.
Cargo.toml	Cleans up the clap version pin to match the resolved lock version (4.6.1); no other functional changes.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant IC as IssueConversation
    participant App as App (mod.rs)
    participant Pump as EventPump
    participant Editor as External Editor

    note over IC: User presses 'e' to edit
    IC->>App: "Action::OpenExternalEditor { issue_number, target, body }"
    App->>Pump: stop_event_pump()
    App->>App: ratatui::restore() + finish_teardown()
    App->>Editor: "spawn_blocking(edit::edit(&initial_body))"
    Editor-->>App: "Result<String, String>"
    App->>App: ratatui::init() + setup_terminal()
    App->>Pump: start_event_pump()
    App->>IC: Action::IssueBodyEditFinished / IssueCommentEditFinished
    App->>App: Action::ForceRender

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant IC as IssueConversation
    participant App as App (mod.rs)
    participant Pump as EventPump
    participant Editor as External Editor

    note over IC: User presses 'e' to edit
    IC->>App: "Action::OpenExternalEditor { issue_number, target, body }"
    App->>Pump: stop_event_pump()
    App->>App: ratatui::restore() + finish_teardown()
    App->>Editor: "spawn_blocking(edit::edit(&initial_body))"
    Editor-->>App: "Result<String, String>"
    App->>App: ratatui::init() + setup_terminal()
    App->>Pump: start_event_pump()
    App->>IC: Action::IssueBodyEditFinished / IssueCommentEditFinished
    App->>App: Action::ForceRender

Loading

Comments Outside Diff (2)

1. crates/hyperrat/src/lib.rs, line 267-271 (link)

   Inverted assertion during CellDiffOption migration

   The old assertion was assert!(!cell.skip) — meaning tail cells (beyond the rendered label width) must not be marked skip. The migration changed this to assert!(cell.diff_option == CellDiffOption::Skip), which is the logical opposite. Since clear_area_row explicitly sets every cell to CellDiffOption::None, these tail cells will always have None after a render, so this assertion will fail every time cargo test runs against the hyperrat crate.

2. crates/hyperrat/src/lib.rs, line 253-258 (link)

   Skip-cell symbol mismatch breaks the test assertion

   The OSC8 render path was updated to store "s" as the placeholder symbol in skip cells (cell.set_symbol("s")), replacing the previous " ". However, this test still asserts cell.symbol() == " " for those same cells. When osc8_supported() returns true (the common case in most test environments), cells at offsets 1..label_width will contain "s", causing the assertion to fail.

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into rollup_2" | Re-trigger Greptile}

[greptile-apps]

Trailing whitespace on this line.

Suggested change

	steps:
	steps:

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[github-actions]

Bencher Report

Branch	rollup_2
Testbed	Linux

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
issue_list_preview/repeat_1/120	📈 view plot ⚠️ NO THRESHOLD	24.00 µs
issue_list_preview/repeat_1/40	📈 view plot ⚠️ NO THRESHOLD	24.52 µs
issue_list_preview/repeat_1/80	📈 view plot ⚠️ NO THRESHOLD	25.28 µs
issue_list_preview/repeat_12/120	📈 view plot ⚠️ NO THRESHOLD	324.18 µs
issue_list_preview/repeat_12/40	📈 view plot ⚠️ NO THRESHOLD	309.42 µs
issue_list_preview/repeat_12/80	📈 view plot ⚠️ NO THRESHOLD	325.22 µs
issue_list_preview/repeat_32/120	📈 view plot ⚠️ NO THRESHOLD	874.67 µs
issue_list_preview/repeat_32/40	📈 view plot ⚠️ NO THRESHOLD	841.30 µs
issue_list_preview/repeat_32/80	📈 view plot ⚠️ NO THRESHOLD	877.77 µs
issue_list_preview/repeat_4/120	📈 view plot ⚠️ NO THRESHOLD	104.51 µs
issue_list_preview/repeat_4/40	📈 view plot ⚠️ NO THRESHOLD	101.40 µs
issue_list_preview/repeat_4/80	📈 view plot ⚠️ NO THRESHOLD	106.04 µs
markdown_render/repeat_1_indent_2/48	📈 view plot ⚠️ NO THRESHOLD	564.89 µs
markdown_render/repeat_1_indent_2/80	📈 view plot ⚠️ NO THRESHOLD	567.55 µs
markdown_render/repeat_1_indent_4/100	📈 view plot ⚠️ NO THRESHOLD	564.47 µs
markdown_render/repeat_2_indent_2/48	📈 view plot ⚠️ NO THRESHOLD	1,148.00 µs
markdown_render/repeat_2_indent_2/80	📈 view plot ⚠️ NO THRESHOLD	1,147.00 µs
markdown_render/repeat_2_indent_4/100	📈 view plot ⚠️ NO THRESHOLD	1,140.00 µs
markdown_render/repeat_6_indent_2/48	📈 view plot ⚠️ NO THRESHOLD	3,472.20 µs
markdown_render/repeat_6_indent_2/80	📈 view plot ⚠️ NO THRESHOLD	3,454.50 µs
markdown_render/repeat_6_indent_4/100	📈 view plot ⚠️ NO THRESHOLD	3,449.10 µs

🐰 View full continuous benchmarking report in Bencher