fix: sync page bugs — pending actions, team counts, setup wizard, watch start

- Filter already-configured folders from pending UI + dismiss stale offers
- Add dismiss_pending_folder() to SyncthingClient
- Pass through member_count/project_count in teamsList mapping
- Add SyncStatusTeamEntry type, clean up unsafe casts in TeamSelector
- Fix SetupWizard sending wrong body to add-project API
- Fix watch start sending JSON body instead of query param
- Fix $derived() → $derived.by() for member/project count derivations
- Remove dead ternary and redundant $effect
- Fix encode_project_path('') when path is empty

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: JayantDevkar

api/routers/sync_status.py

@@ -262,6 +262,40 @@ def rescan_all(self) -> dict:
                 pass
         return {"ok": True, "scanned": scanned}
 
+    def get_pending_folders_for_ui(
+        self, known_devices: dict[str, tuple[str, str]]
+    ) -> list[dict]:
+        """Get pending folder offers filtered for known team members.
+
+        Args:
+            known_devices: {device_id: (member_name, team_name)}
+
+        Returns:
+            List of pending offers from known members with karma- prefix only.
+        """
+        client = self._require_client()
+        pending = client.get_pending_folders()
+        existing_ids = {f["id"] for f in client.get_folders()}
+        result = []
+
+        for folder_id, info in pending.items():
+            if not folder_id.startswith("karma-"):
+                continue
+            if folder_id in existing_ids:
+                continue
+            for device_id, offer in info.get("offeredBy", {}).items():
+                if device_id not in known_devices:
+                    continue
+                member_name, team_name = known_devices[device_id]
+                result.append({
+                    "folder_id": folder_id,
+                    "from_device": device_id,
+                    "from_member": member_name,
+                    "from_team": team_name,
+                    "offered_at": offer.get("time"),
+                })
+        return result
+
     def get_bandwidth(self) -> dict:
         """Return current bandwidth totals from connections endpoint."""
         client = self._require_client()

api/services/syncthing_proxy.py

@@ -82,14 +82,33 @@ def _accept_pending_folders(st, config):
 
     accepted = 0
 
+    # Get existing folder IDs to avoid duplicates
+    existing_folder_ids = {f["id"] for f in st.get_folders()}
+    own_device_id = config.syncthing.device_id if config.syncthing else None
+
     for folder_id, folder_info in pending.items():
         # Security: only accept karma-prefixed folders
         if not folder_id.startswith("karma-"):
             click.echo(f"  Skipped non-karma folder offer '{folder_id}' (security policy)")
             continue
 
+        # Skip folders we already have configured (e.g. our own outbox)
+        if folder_id in existing_folder_ids:
+            # Dismiss the pending offer so it doesn't reappear
+            for device_id in folder_info.get("offeredBy", {}):
+                try:
+                    st.dismiss_pending_folder(folder_id, device_id)
+                except Exception:
+                    pass
+            click.echo(f"  Dismissed '{folder_id}' (already configured locally)")
+            continue
+
         offered_by = folder_info.get("offeredBy", {})
         for device_id, _offer in offered_by.items():
+            # Skip offers from our own device
+            if own_device_id and device_id == own_device_id:
+                continue
+
             if device_id not in known_devices:
                 short_id = device_id[:20] + "..."
                 click.echo(f"  Skipped folder '{folder_id}' from unknown device {short_id}")
@@ -128,10 +147,11 @@ def _accept_pending_folders(st, config):
 
             # Accept: create the folder as receiveonly
             inbox_devices = [device_id]
-            if config.syncthing and config.syncthing.device_id:
-                inbox_devices.append(config.syncthing.device_id)
+            if own_device_id:
+                inbox_devices.append(own_device_id)
             Path(inbox_path).mkdir(parents=True, exist_ok=True)
             st.add_folder(folder_id, inbox_path, inbox_devices, folder_type="receiveonly")
+            existing_folder_ids.add(folder_id)
 
             click.echo(
                 f"  Accepted '{folder_id}' from {member_name} "

cli/karma/main.py

@@ -142,6 +142,15 @@ def get_pending_folders(self) -> dict:
         resp.raise_for_status()
         return resp.json()
 
+    def dismiss_pending_folder(self, folder_id: str, device_id: str) -> None:
+        """Dismiss a pending folder offer so it no longer appears."""
+        requests.delete(
+            f"{self.api_url}/rest/cluster/pending/folders",
+            headers=self.headers,
+            params={"folder": folder_id, "device": device_id},
+            timeout=10,
+        )
+
     def get_folders(self) -> list[dict]:
         """Get all configured folders."""
         config = self._get_config()

cli/karma/syncthing.py

@@ -1697,11 +1697,17 @@ export interface SyncDetect {
 	device_id: string | null;
 }
 
+export interface SyncStatusTeamEntry {
+	backend: 'syncthing' | 'ipfs';
+	member_count: number;
+	project_count: number;
+}
+
 export interface SyncStatusResponse {
 	configured: boolean;
 	user_id?: string;
 	machine_id?: string;
-	teams?: Record<string, unknown>;
+	teams?: Record<string, SyncStatusTeamEntry>;
 }
 
 export interface SyncDevice {
@@ -1734,6 +1740,8 @@ export interface SyncTeam {
 	backend: 'syncthing' | 'ipfs';
 	projects: SyncTeamProject[];
 	members: SyncTeamMember[];
+	member_count?: number;
+	project_count?: number;
 }
 
 export interface SyncTeamProject {

frontend/src/lib/api-types.ts

@@ -41,11 +41,9 @@
 		if (!teamName) return;
 		watchActing = true;
 		try {
-			const res = await fetch(`${API_BASE}/sync/watch/start`, {
-				method: 'POST',
-				headers: { 'Content-Type': 'application/json' },
-				body: JSON.stringify({ team: teamName })
-			}).catch(() => null);
+			const url = new URL(`${API_BASE}/sync/watch/start`, window.location.origin);
+			if (teamName) url.searchParams.set('team_name', teamName);
+			const res = await fetch(url.toString(), { method: 'POST' }).catch(() => null);
 			if (res?.ok) {
 				watchStatus = await res.json();
 			}
@@ -108,7 +106,7 @@
 
 	type TeamEntry = { member_count?: number; project_count?: number; members?: unknown[] };
 
-	let derivedMemberCount = $derived(() => {
+	let derivedMemberCount = $derived.by(() => {
 		if (!status?.teams) return 0;
 		let count = 0;
 		for (const team of Object.values(status.teams) as TeamEntry[]) {
@@ -117,7 +115,7 @@
 		return count;
 	});
 
-	let derivedProjectCount = $derived(() => {
+	let derivedProjectCount = $derived.by(() => {
 		if (!status?.teams) return 0;
 		let count = 0;
 		for (const team of Object.values(status.teams) as TeamEntry[]) {
@@ -128,8 +126,8 @@
 
 	async function loadStats() {
 		statsLoading = true;
-		memberCount = derivedMemberCount();
-		projectCount = derivedProjectCount();
+		memberCount = derivedMemberCount;
+		projectCount = derivedProjectCount;
 		try {
 			const res = await fetch(`${API_BASE}/sync/projects`).catch(() => null);
 			if (res?.ok) {

frontend/src/lib/components/sync/OverviewTab.svelte

@@ -218,7 +218,7 @@
 						fetch(`${API_BASE}/sync/teams/${encodeURIComponent(name)}/projects`, {
 							method: 'POST',
 							headers: { 'Content-Type': 'application/json' },
-							body: JSON.stringify({ encoded_name: encodedName })
+							body: JSON.stringify({ name: encodedName, path: '' })
 						})
 					)
 				);

frontend/src/lib/components/sync/SetupWizard.svelte

@@ -18,14 +18,12 @@
 
 	let memberCount = $derived(
 		activeTeamObj
-			? ((activeTeamObj as unknown as Record<string, unknown>).member_count as number) ??
-				(Array.isArray(activeTeamObj.members) ? activeTeamObj.members.length : 0)
+			? activeTeamObj.member_count ?? activeTeamObj.members.length
 			: 0
 	);
 	let projectCount = $derived(
 		activeTeamObj
-			? ((activeTeamObj as unknown as Record<string, unknown>).project_count as number) ??
-				(Array.isArray(activeTeamObj.projects) ? activeTeamObj.projects.length : 0)
+			? activeTeamObj.project_count ?? activeTeamObj.projects.length
 			: 0
 	);
 
@@ -123,8 +121,8 @@
 							aria-label="Select team"
 						>
 							{#each teams as team (team.name)}
-								{@const tMembers = (team as unknown as Record<string, unknown>).member_count as number ?? (Array.isArray(team.members) ? team.members.length : 0)}
-								{@const tProjects = (team as unknown as Record<string, unknown>).project_count as number ?? (Array.isArray(team.projects) ? team.projects.length : 0)}
+								{@const tMembers = team.member_count ?? team.members.length}
+								{@const tProjects = team.project_count ?? team.projects.length}
 								<button
 									onclick={() => selectTeam(team.name)}
 									role="option"

frontend/src/lib/components/sync/TeamSelector.svelte

@@ -20,21 +20,21 @@
 	let syncDetect = $state<SyncDetect | null>(data.detect ?? null);
 	let syncStatus = $state<SyncStatusResponse | null>(data.status ?? null);
 
-	let activeTab = $state(
-		data.activeTab ?? (data.status?.configured ? 'overview' : 'overview')
-	);
+	let activeTab = $state(data.activeTab ?? 'overview');
 
 	// ── Team selection ───────────────────────────────────────────────────────
 	let activeTeamName = $state('');
 
 	// Derive teams array from syncStatus.teams Record
 	let teamsList = $derived.by<SyncTeam[]>(() => {
 		if (!syncStatus?.teams) return [];
-		return Object.entries(syncStatus.teams).map(([name, value]) => ({
+		return Object.entries(syncStatus.teams).map(([name, entry]) => ({
 			name,
-			backend: ((value as Record<string, unknown>).backend as 'syncthing' | 'ipfs') ?? 'syncthing',
-			projects: ((value as Record<string, unknown>).projects as SyncTeam['projects']) ?? [],
-			members: ((value as Record<string, unknown>).members as SyncTeam['members']) ?? []
+			backend: entry.backend ?? 'syncthing',
+			projects: [],
+			members: [],
+			member_count: entry.member_count ?? 0,
+			project_count: entry.project_count ?? 0
 		}));
 	});
 
@@ -75,13 +75,6 @@
 		history.replaceState(null, '', url.toString());
 	});
 
-	// Update seconds since last update
-	$effect(() => {
-		if (lastUpdated) {
-			secondsSinceUpdate = Math.floor((Date.now() - lastUpdated.getTime()) / 1000);
-		}
-	});
-
 	async function refreshData() {
 		if (isFetching) return;
 		isFetching = true;