Remove innecesary calls to getInstance

Author: javizqh

react_frontend/src/components/buttons/PlayPause.tsx

@@ -37,9 +37,7 @@ const PlayPauseButton = ({
   const entrypointRef = useRef<Entry | undefined>(undefined);
   const runningFilesRef = useRef<Entry[]>([]);
   const runningEntrypointRef = useRef<Entry | undefined>(undefined);
-  const [state, setState] = useState<string>(
-    CommsManager.getInstance().getState()
-  );
+  const [state, setState] = useState<string>(states.IDLE);
   const [loading, setLoading] = useState<boolean>(false);
   const isCodeUpdatedRef = useRef<boolean | undefined>(undefined);
   const [, _updateCode] = useState<boolean | undefined>(false);

react_frontend/src/components/layouts/ExerciseContainer.tsx

@@ -19,7 +19,7 @@ import {
 import Frequencies from "Components/statusBar/Frequencies";
 import { StyledExerciseContainer } from "Styles/layouts/ExerciseContainer.styles";
 import { getHalGuiMethods } from "Helpers/editor";
-import { subscribe, unsubscribe } from "Helpers/utils";
+import { clearTimeouts, subscribe, unsubscribe } from "Helpers/utils";
 import { fileExplorer } from "Helpers/explorer";
 import getTools from "Helpers/tools";
 
@@ -66,9 +66,6 @@ const ExerciseContainer = ({
     setUniverses(list);
   };
 
-  // RB manager setup
-  const connected = useRef<boolean>(false);
-
   const resetUniverse = (e: unknown) => {
     const T = CustomEvent<{ detail: unknown }>;
     if (e instanceof T) {
@@ -93,13 +90,7 @@ const ExerciseContainer = ({
         }
       }
 
-      if (timeoutRef.current) {
-        window.clearTimeout(timeoutRef.current);
-      }
-
-      if (connectTimeoutRef.current) {
-        window.clearTimeout(connectTimeoutRef.current);
-      }
+      clearTimeouts([timeoutRef, connectTimeoutRef]);
     };
   }, []);
 
@@ -113,7 +104,6 @@ const ExerciseContainer = ({
       await currManager.connect();
       getUniverseList(project);
       console.log("Connected!", currManager.getState());
-      connected.current = true;
       setManager(currManager);
       if (callback) {
         waitManagerState(desiredState ? desiredState : "connected", callback);

react_frontend/src/helpers/utils.ts

@@ -1,6 +1,7 @@
 import { getFile, getHelperFile } from "Api";
 import { Entry } from "jderobot-ide-interface";
 import JSZip from "jszip";
+import { MutableRefObject } from "react";
 
 export const saveCode = (
   fileName: string,
@@ -142,3 +143,13 @@ const zipCodeFolder = async (zip: JSZip, file: Entry, project: string) => {
     }
   }
 };
+
+export const clearTimeouts = (
+  timeoutsRef: MutableRefObject<number | null>[]
+) => {
+  for (const element of timeoutsRef) {
+    if (element.current) {
+      window.clearTimeout(element.current);
+    }
+  }
+};