fix: remove unused local variables in classnet and lap#3723
Merged
javizqh merged 1 commit intoJdeRobot:humble-develfrom Apr 10, 2026
Merged
fix: remove unused local variables in classnet and lap#3723javizqh merged 1 commit intoJdeRobot:humble-develfrom
javizqh merged 1 commit intoJdeRobot:humble-develfrom
Conversation
- Remove unused rows and cols variables in NeuralNetwork.detect() in classnet.py (they are only needed in getBoundingBoxes()) - Remove unused pose3d local variable in Lap.check_threshold() in follow_line/lap.py
Member
|
Next time please submit PR that are relevant to the issues open |
Contributor
Author
|
@javizqh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes two unused local variable assignments identified during code review.
Changes
common/hal_interfaces/hal_interfaces/general/classnet.py
rowsandcolsassignments insideNeuralNetwork.detect()— these variables are computed but never used within that method. The correct usage ofrowsandcolsalready exists ingetBoundingBoxes()where they are actually needed.exercises/follow_line/python_template/lap.py
pose3d = self.pose3d.getPose3d()insideLap.check_threshold()— the result is assigned but never referenced anywhere in the method body.Testing
blackon both files — passes cleanly with no formatting changes needed