Adjust position calculation for MoreActionsMenu#44
Open
JitinSaxenaa wants to merge 1 commit into
Open
Conversation
The MoreActionsMenu dropdown was previously positioned using hardcoded values (x: 200 + 20 and event.pageY), which caused misalignment issues depending on layout size, scroll position, and viewport changes. This update anchors the dropdown to the clicked element using getBoundingClientRect(), ensuring consistent and accurate positioning relative to the trigger button. Changes: - Replaced hardcoded x-offset with element-based positioning. - Used rect.right and rect.bottom for stable alignment. - Removed dependency on pageY and static pixel values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MoreActionsMenu dropdown was previously positioned using hardcoded values (x: 200 + 20 and event.pageY), which caused misalignment issues depending on layout size, scroll position, and viewport changes.
This update anchors the dropdown to the clicked element using getBoundingClientRect(), ensuring consistent and accurate positioning relative to the trigger button.
Changes: