Skip to content

Commit 2ebd2f3

Browse files
Merge branch 'develop' into user/kernel/fix-command-buffer-manager
2 parents 2f40f5f + 27ab2f4 commit 2ebd2f3

File tree

7 files changed

+62
-23
lines changed

7 files changed

+62
-23
lines changed

CMakePresets.json

Lines changed: 35 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@
5757
}
5858
},
5959
{
60-
"name": "Windows_x64_Debug",
60+
"name": "Windows_x64_Debug_2022",
6161
"inherits": "BaseOptions",
62-
"displayName": "Windows Visual Studio Debug",
62+
"displayName": "Windows Visual Studio 2022 Debug",
6363
"generator": "Visual Studio 17 2022",
6464
"binaryDir": "Result.Windows.x64.MultiConfig",
6565
"architecture": "x64",
@@ -70,14 +70,28 @@
7070

7171
},
7272
{
73-
"name": "Windows_x64_Release",
74-
"displayName": "Windows Visual Studio Release",
75-
"inherits": "Windows_x64_Debug",
73+
"name": "Windows_x64_Release_2022",
74+
"displayName": "Windows Visual Studio 2022 Release",
75+
"inherits": "Windows_x64_Debug_2022",
7676
"cacheVariables": {
7777
"CMAKE_CONFIGURATION_TYPES": "Release"
7878
}
7979
},
8080

81+
{
82+
"name": "Windows_x64_Debug_2026",
83+
"inherits": "Windows_x64_Debug_2022",
84+
"displayName": "Windows Visual Studio 2026 Debug",
85+
"generator": "Visual Studio 18 2026"
86+
},
87+
88+
{
89+
"name": "Windows_x64_Release_2026",
90+
"inherits": "Windows_x64_Release_2022",
91+
"displayName": "Windows Visual Studio 2026 Release",
92+
"generator": "Visual Studio 18 2026"
93+
},
94+
8195
{
8296
"name": "Darwin_x64_Debug",
8397
"inherits": "BaseOptions",
@@ -147,22 +161,34 @@
147161

148162
"buildPresets": [
149163
{
150-
"name": "Windows_x64_Debug",
151-
"configurePreset": "Windows_x64_Debug",
164+
"name": "Windows_x64_Debug_2022",
165+
"configurePreset": "Windows_x64_Debug_2022",
152166
"configuration": "Debug",
153167
"nativeToolOptions": [
154168
"-nodeReuse:false"
155169
]
156170
},
157171
{
158-
"name": "Windows_x64_Release",
159-
"configurePreset": "Windows_x64_Release",
172+
"name": "Windows_x64_Release_2022",
173+
"configurePreset": "Windows_x64_Release_2022",
160174
"configuration": "Release",
161175
"nativeToolOptions": [
162176
"-nodeReuse:false"
163177
]
164178
},
165179

180+
{
181+
"name": "Windows_x64_Debug_2026",
182+
"inherits": "Windows_x64_Debug_2022",
183+
"configurePreset": "Windows_x64_Debug_2026"
184+
},
185+
186+
{
187+
"name": "Windows_x64_Release_2026",
188+
"inherits": "Windows_x64_Release_2022",
189+
"configurePreset": "Windows_x64_Release_2026"
190+
},
191+
166192
{
167193
"name": "Darwin_x64_Debug",
168194
"configuration": "Debug",

Scripts/BuildEngine.ps1

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ param (
4242
[bool] $VerifyFormatting = $False,
4343

4444
[Parameter(HelpMessage = "VS version use to build, default to 2022")]
45-
[ValidateSet(2022)]
45+
[ValidateSet('2022', '2026')]
4646
[int] $VsVersion = 2022,
4747

4848
[Parameter(HelpMessage = "Build Launcher only")]
@@ -121,6 +121,10 @@ function Build([string]$configuration, [int]$VsVersion , [bool]$runBuild) {
121121
# Define CMake Generator arguments
122122
$configName = $systemName, $architecture, $configuration -join "_"
123123

124+
if($IsWindows){
125+
$configName += '_'+$VsVersion
126+
}
127+
124128
$cMakeArguments = " --preset $configName $cMakeCacheVariableOverride"
125129

126130
# CMake Generation process
@@ -130,8 +134,9 @@ function Build([string]$configuration, [int]$VsVersion , [bool]$runBuild) {
130134
throw "cmake failed generation for '$cMakeArguments' with exit code '$cMakeProcess.ExitCode'"
131135
}
132136

137+
138+
if ($runBuild) {
133139
# CMake Build Process
134-
#
135140

136141
Write-Host "Building $systemName $architecture $configuration"
137142

@@ -166,6 +171,7 @@ function Build([string]$configuration, [int]$VsVersion , [bool]$runBuild) {
166171
if($installProcess.ExitCode -ne 0){
167172
throw "cmake failed to install to '$install_directory'"
168173
}
174+
}
169175
}
170176

171177

Tetragrama/Components/DockspaceUIComponent.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ namespace Tetragrama::Components
4040
m_editor_serializer->Initialize(parent->Arena);
4141
m_asset_importer->Initialize(parent->Arena);
4242

43-
m_dockspace_node_flag = ImGuiDockNodeFlags_NoWindowMenuButton | ImGuiDockNodeFlags_PassthruCentralNode;
43+
m_dockspace_node_flag = ImGuiDockNodeFlags_NoWindowMenuButton | static_cast<decltype(ImGuiDockNodeFlags_NoWindowMenuButton)>(ImGuiDockNodeFlags_PassthruCentralNode);
4444
m_window_flags = ImGuiWindowFlags_MenuBar | ImGuiWindowFlags_NoDocking | ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoCollapse | ImGuiWindowFlags_NoResize | ImGuiWindowFlags_NoMove | ImGuiWindowFlags_NoBringToFrontOnFocus | ImGuiWindowFlags_NoNavFocus;
4545

4646
auto app = reinterpret_cast<EditorPtr>(ParentLayer->CurrentApp);
@@ -211,7 +211,7 @@ namespace Tetragrama::Components
211211

212212
ImGui::PushFont(ImGui::GetIO().Fonts->Fonts[0]);
213213
ImGui::SetCursorPos(ImVec2(10, ImGui::GetWindowSize().y - 30));
214-
ImGui::TextColored(s_asset_importer_report_msg_color, s_asset_importer_report_msg.c_str());
214+
ImGui::TextColored(s_asset_importer_report_msg_color, "%s", s_asset_importer_report_msg.c_str());
215215
ImGui::PopFont();
216216

217217
ImGui::EndPopup();
@@ -244,7 +244,7 @@ namespace Tetragrama::Components
244244

245245
ImGui::PushFont(ImGui::GetIO().Fonts->Fonts[0]);
246246
ImGui::SetCursorPos(ImVec2(10, wind_size.y - 30));
247-
ImGui::TextColored(s_scene_serializer_log_color, s_scene_serializer_log);
247+
ImGui::TextColored(s_scene_serializer_log_color, "%s", s_scene_serializer_log);
248248
ImGui::PopFont();
249249

250250
ImGui::EndPopup();
@@ -385,7 +385,7 @@ namespace Tetragrama::Components
385385

386386
if (ImGui::BeginPopupModal(str_id, NULL, ImGuiWindowFlags_AlwaysAutoResize))
387387
{
388-
ImGui::Text(fmt::format("You have unsaved changes for your current scene : {}", current_scene->Name).c_str());
388+
ImGui::Text("%s", fmt::format("You have unsaved changes for your current scene : {}", current_scene->Name).c_str());
389389
ImGui::Separator();
390390

391391
if (ImGui::Button("Save", ImVec2(120, 0)))

Tetragrama/Messengers/Messenger.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ namespace Tetragrama::Messengers
141141
// catch (...)
142142
//{
143143
//}
144+
return {};
144145
}
145146

146147
template <typename TRecipient, typename TMessage>

ZEngine/ZEngine/Hardwares/VulkanDevice.cpp

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -696,22 +696,22 @@ namespace ZEngine::Hardwares
696696

697697
VKAPI_ATTR VkBool32 VKAPI_CALL VulkanDevice::__debugCallback(VkDebugUtilsMessageSeverityFlagBitsEXT messageSeverity, VkDebugUtilsMessageTypeFlagsEXT messageType, const VkDebugUtilsMessengerCallbackDataEXT* pCallbackData, void* pUserData)
698698
{
699-
if ((messageSeverity & VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT) == VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT)
699+
if ((messageSeverity & static_cast<decltype(messageSeverity)>(VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT)) == VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT)
700700
{
701701
ZENGINE_CORE_ERROR("{}", pCallbackData->pMessage)
702702
}
703703

704-
if ((messageSeverity & VK_DEBUG_UTILS_MESSAGE_SEVERITY_WARNING_BIT_EXT) == VK_DEBUG_UTILS_MESSAGE_SEVERITY_WARNING_BIT_EXT)
704+
if ((messageSeverity & static_cast<decltype(messageSeverity)>(VK_DEBUG_UTILS_MESSAGE_SEVERITY_WARNING_BIT_EXT)) == VK_DEBUG_UTILS_MESSAGE_SEVERITY_WARNING_BIT_EXT)
705705
{
706706
ZENGINE_CORE_WARN("{}", pCallbackData->pMessage)
707707
}
708708

709-
if ((messageSeverity & VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT) == VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT)
709+
if ((messageSeverity & static_cast<decltype(messageSeverity)>(VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT)) == VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT)
710710
{
711711
ZENGINE_CORE_WARN("{}", pCallbackData->pMessage)
712712
}
713713

714-
if ((messageSeverity & VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT) == VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT)
714+
if ((messageSeverity & static_cast<decltype(messageSeverity)>(VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT)) == VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT)
715715
{
716716
ZENGINE_CORE_WARN("{}", pCallbackData->pMessage)
717717
}
@@ -936,6 +936,8 @@ namespace ZEngine::Hardwares
936936
dst_access_mask = VK_ACCESS_INDIRECT_COMMAND_READ_BIT;
937937
dst_pipeline_stage = VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT;
938938
break;
939+
case UNKNOWN:
940+
break;
939941
}
940942

941943
VkBufferMemoryBarrier bufMemBarrier2 = {VK_STRUCTURE_TYPE_BUFFER_MEMORY_BARRIER};
@@ -1237,6 +1239,8 @@ namespace ZEngine::Hardwares
12371239
vkFreeDescriptorSets(LogicalDevice, reinterpret_cast<VkDescriptorPool>(res_handle.Data1), 1, &ds);
12381240
break;
12391241
}
1242+
case DeviceResourceType::RESOURCE_COUNT:
1243+
break;
12401244
}
12411245

12421246
DirtyResources.Remove(handle);
@@ -2085,7 +2089,7 @@ namespace ZEngine::Hardwares
20852089

20862090
void Image2DBuffer::Dispose()
20872091
{
2088-
if (this && m_buffer_image)
2092+
if (m_buffer_image)
20892093
{
20902094
Device->EnqueueBufferImageForDeletion(m_buffer_image);
20912095
m_buffer_image = {};
@@ -2223,6 +2227,8 @@ namespace ZEngine::Hardwares
22232227
dst_access_mask = VK_ACCESS_INDIRECT_COMMAND_READ_BIT;
22242228
dst_pipeline_stage = VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT;
22252229
break;
2230+
case UNKNOWN:
2231+
break;
22262232
}
22272233

22282234
auto command_buffer_info = m_device->CommandBufferMgr->GetInstantCommandBuffer(Rendering::QueueType::GRAPHIC_QUEUE, (m_device->SwapchainPtr->CurrentFrame == nullptr ? 0u : m_device->SwapchainPtr->CurrentFrame->Index), 0, 2, true);

ZEngine/ZEngine/Helpers/HandleManager.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ namespace ZEngine::Helpers
1818
template <typename T>
1919
struct Handle
2020
{
21-
uint32_t Index = UINT32_MAX;
21+
uint64_t Index = UINT64_MAX;
2222

2323
bool Valid() const
2424
{
25-
return Index != UINT32_MAX;
25+
return Index != UINT64_MAX;
2626
}
2727

2828
operator bool() const

dependencies.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ FetchContent_Declare(
4747
EnTT
4848
GIT_REPOSITORY https://github.com/skypjack/entt.git
4949
GIT_SHALLOW TRUE
50-
GIT_TAG main
50+
GIT_TAG v3.16.0
5151
)
5252

5353
FetchContent_Declare(

0 commit comments

Comments
 (0)