Skip to content

Commit 5f6a704

Browse files
fixing cstring comparaison on Shader Binding name & updating gitignore file (#491)
* fixed binding name cmp * added more build dirs to git ignore
1 parent 764ce46 commit 5f6a704

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ bld/
3131
[Rr]esult.[Ww]indows.[Xx]64.[Mm]ulti[Cc]onfig/
3232
[Rr]esult.[Ll]inux.[Xx]64.[Dd]ebug/
3333
[Rr]esult.[Ll]inux.[Xx]64.[Rr]elease/
34+
[Rr]esult.[Ll]inux.[Aa][Rr][Mm]64.[Rr]elease/
35+
[Rr]esult.[Ll]inux.[Aa][Rr][Mm]64.[Dd]ebug/
3436
[Rr]esult.[Dd]arwin.[Xx]64.[Dd]ebug/
3537
[Rr]esult.[Dd]arwin.[Xx]64.[Rr]elease/
38+
[Rr]esult.[Dd]arwin.[Aa][Rr][Mm]64.[Dd]ebug/
39+
[Rr]esult.[Dd]arwin.[Aa][Rr][Mm]64.[Rr]elease/
3640

3741
# Submodules folder
3842
__externals/fmt

ZEngine/ZEngine/Rendering/Shaders/Shader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ namespace ZEngine::Rendering::Shaders
236236
for (const auto& layout_binding : LayoutBindingSpecificationMap)
237237
{
238238
const auto& binding_specification_collection = layout_binding.second;
239-
auto find_it = std::find_if(binding_specification_collection.begin(), binding_specification_collection.end(), [&](const LayoutBindingSpecification& spec) { return spec.Name == name; });
239+
auto find_it = std::find_if(binding_specification_collection.begin(), binding_specification_collection.end(), [&](const LayoutBindingSpecification& spec) { return Helpers::secure_strcmp(spec.Name, name); });
240240

241241
if (find_it != std::end(binding_specification_collection))
242242
{

0 commit comments

Comments
 (0)