Skip to content

fixing cstring comparaison on Shader Binding name & updating gitignore file #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeanPhilippeKernel merged 2 commits into from
Jan 19, 2026
Merged

fixing cstring comparaison on Shader Binding name & updating gitignore file #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a835e3d
fixed binding name cmp
JeanPhilippeKernel Jan 19, 2026
80b1795
added more build dirs to git ignore
JeanPhilippeKernel Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ bld/
[Rr]esult.[Ww]indows.[Xx]64.[Mm]ulti[Cc]onfig/
[Rr]esult.[Ll]inux.[Xx]64.[Dd]ebug/
[Rr]esult.[Ll]inux.[Xx]64.[Rr]elease/
[Rr]esult.[Ll]inux.[Aa][Rr][Mm]64.[Rr]elease/
[Rr]esult.[Ll]inux.[Aa][Rr][Mm]64.[Dd]ebug/
[Rr]esult.[Dd]arwin.[Xx]64.[Dd]ebug/
[Rr]esult.[Dd]arwin.[Xx]64.[Rr]elease/
[Rr]esult.[Dd]arwin.[Aa][Rr][Mm]64.[Dd]ebug/
[Rr]esult.[Dd]arwin.[Aa][Rr][Mm]64.[Rr]elease/

# Submodules folder
__externals/fmt
Expand Down
2 changes: 1 addition & 1 deletion ZEngine/ZEngine/Rendering/Shaders/Shader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ namespace ZEngine::Rendering::Shaders
for (const auto& layout_binding : LayoutBindingSpecificationMap)
{
const auto& binding_specification_collection = layout_binding.second;
auto find_it = std::find_if(binding_specification_collection.begin(), binding_specification_collection.end(), [&](const LayoutBindingSpecification& spec) { return spec.Name == name; });
auto find_it = std::find_if(binding_specification_collection.begin(), binding_specification_collection.end(), [&](const LayoutBindingSpecification& spec) { return Helpers::secure_strcmp(spec.Name, name); });

if (find_it != std::end(binding_specification_collection))
{
Expand Down
Loading