Skip to content

Fix Warnings raised during compilation#505

Merged
JeanPhilippeKernel merged 1 commit into
JeanPhilippeKernel:developfrom
MathewBensonCode:fix_warnings
Mar 5, 2026
Merged

Fix Warnings raised during compilation#505
JeanPhilippeKernel merged 1 commit into
JeanPhilippeKernel:developfrom
MathewBensonCode:fix_warnings

Conversation

@MathewBensonCode
Copy link
Copy Markdown
Contributor

Attempted to fix the warnings that would persistently come up when compiling. These are possibly a source of bugs.

Changes made include:j

  • use String version of ImGui calls in DockspaceUIComponent
  • Change Handle::Index from uint32_t to uint64_t because it is we are using it to represent a void* and as we are generally targeting x64 the system would warn about this conversion.
  • Used static_casts to deal with enum-to-enum comparisons using different enum types.
  • return default typed Node in Messenger.h
  • Close off switch statements with a default clause.

- use String version of ImGui calls in DockspaceUIComponent
- Change Handle::Index from uint32_t to uint64_t because it is we are
  using it to represent a void* and as we are generally targeting x64
  the system would warn about this conversion.
- Used static_casts to deal with enum-to-enum comparisons using
  different enum types.
- return default typed Node in Messenger.h
- Close off switch statements with a default clause.
@JeanPhilippeKernel JeanPhilippeKernel added the enhancement New feature or request label Mar 5, 2026
@JeanPhilippeKernel JeanPhilippeKernel added this to the Born baby (0.2.0) milestone Mar 5, 2026
@JeanPhilippeKernel JeanPhilippeKernel moved this to In Progress in ZEngine Board Mar 5, 2026
@JeanPhilippeKernel JeanPhilippeKernel merged commit 27ab2f4 into JeanPhilippeKernel:develop Mar 5, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in ZEngine Board Mar 5, 2026
@MathewBensonCode MathewBensonCode deleted the fix_warnings branch March 16, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants