fix: improved HandleManager threading mgmt support#521
Open
JeanPhilippeKernel wants to merge 1 commit intodevelopfrom
Open
fix: improved HandleManager threading mgmt support#521JeanPhilippeKernel wants to merge 1 commit intodevelopfrom
JeanPhilippeKernel wants to merge 1 commit intodevelopfrom
Conversation
e864019 to
277911a
Compare
277911a to
e2e03f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I took the stab to revisit the implementation of
HandleManagerto make it more thread-safe and more stable around the handle versioning process.In addition to this, we fixed a resizing issue that was happening when user tries to manipulate the viewport component.