chore: update rhiza to v1.2.1 - #889
Merged
Merged
Conversation
Bump reusable workflow refs from v1.2.0 to v1.2.1 and update the template lock (opt out of fuzzing/scorecard/weekly workflows). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Rhiza template pin to v1.2.1 and syncs downstream template-managed artifacts (notably GitHub Actions workflows) so this repo stays aligned with the upstream jebel-quant/rhiza automation.
Changes:
- Bump Rhiza template
reffromv1.2.0→v1.2.1and update the synced template lock metadata (sha, synced_at, profiles/exclude). - Update template-managed GitHub Actions workflow
uses:references to point at@v1.2.1.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .rhiza/template.yml | Bumps the Rhiza template ref to v1.2.1. |
| .rhiza/template.lock | Updates lock sha/ref and synced metadata; records excluded upstream workflow bundles. |
| .github/workflows/rhiza_release.yml | Updates Rhiza action reference to @v1.2.1 for the release workflow. |
| .github/workflows/rhiza_paper.yml | Pins reusable Rhiza workflow to @v1.2.1. |
| .github/workflows/rhiza_mutation.yml | Pins reusable Rhiza workflow to @v1.2.1. |
| .github/workflows/rhiza_marimo.yml | Pins reusable Rhiza workflow to @v1.2.1. |
| .github/workflows/rhiza_codeql.yml | Pins reusable Rhiza workflow to @v1.2.1. |
| .github/workflows/rhiza_ci.yml | Pins reusable Rhiza workflow to @v1.2.1. |
| .github/workflows/rhiza_book.yml | Pins reusable Rhiza workflow to @v1.2.1. |
| .github/workflows/rhiza_benchmark.yml | Pins reusable Rhiza workflow to @v1.2.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reftov1.2.1in.rhiza/template.yml(fromv1.2.0)github-project(unchanged; matches the GitHub origin)scripts/sync.pyto apply upstream template changes; the 8 workflow conflicts were resolved taking the upstream side (all were theuses: …@v1.2.0→@v1.2.1ref bump)Quality gates
make fmt(lint/format/pre-commit)make typecheck(ty + mypy --strict, 52 files)make docs-coverage(interrogate)make deptry(dependency hygiene)make security(bandit)make validatemake test(suite + coverage gate)check_test_layout.py)¹ 5 kaleido plot tests skipped: no Chrome/Chromium in the environment (environmental, not a code failure).
Scorecard (locally-owned scope)
make fmtfully cleanty+mypy --strictclean over 52 modulesdata.py(808 LOC) and_stats/_performance.py(714 LOC) are the largest_protocol.pyinterface modules), clean layering with cross-package imports flowing only to baseexceptions, no import cyclestests/test_jquantstats/…) rather than the 1:1tests/<pkg>/test_<name>.pymirror the bundled checker enforcesmake validate)Overall: 9/10. Excellent code quality, types, docs, and 100% coverage across a large surface. The single blemish is test-layout parity against the rhiza checker's 1:1 mirror expectation.
Highest-leverage improvement: reconcile test-layout parity — either migrate to the mirrored
tests/<pkg>/test_<name>.pylayout or configure/exempt the checker to accept the behaviour-grouped structure.Recommendations (ordered by leverage)
tests/vssrc/jquantstats/. Done whencheck_test_layout.pyexits 0 (mirror the layout, or record the intentional grouping in the checker config).src/jquantstats/data.py(808 LOC),_stats/_performance.py(714 LOC). Done when nosrc/module exceeds ~500 LOC and radon MI stays grade A.