adding source citations is slow

[HerzScheisse]

Hey Jefferson49,

for quite a while now I've been noticing a strange behaviour and wanted to ask if i'm the only one or if you can also reproduce the error...

when Copy source citation to clipboard and then adding it to a couple of facts via the paste source citation from clipboard icon... it takes 1 to 4 seconds if the page even starts loading....

clicking on the edit fact buttons loads the edit dialogue immediately... so my guess is, its related to the Module... its also happens to the Delete source citation

right now i'm on wt 2.2.5 with your latest release (even both with and without the latest commit not included in the release zip)
but this also happend on wt 2.2.4

the rest of the functions working ok an my server... just wanted to know if you can verify this... so i can dig a bit deeper...

I hope you understood my issue... and if you want to test this i can provide you a test account (just write me a email for credentials)

thanks
/Holger

[Jefferson49]

In my (slow) webtrees installation on Synology-NAS, it takes something between 1 and 3 seconds. Therefore, it seems to be simular to your observations.

By checking the related code e.g. PasteSourceCitation, I could not find any suspicious things.

RepositoryHierarchy calls functions of the following webtrees classes:

• GedcomRecord
• Fact

By checking the history of those webtrees classes, I found the following change in GedcomRecord: "Refactor edit/create/delete fact to allow facts to be added in order" (fisharebest/webtrees@85ca24a)

This could be an explanation. After pasting or moving a source citation, webtrees will reorder all the facts in the record, which might take some time. Ordering of facts (which makes sense) is a new approach. Seemingly it was introduced in December. This matches with your observations.

To dig deeper, we could try some PHP profiling, e.g. pasting a source citation and log, which code takes the most part of the execution time.

[HerzScheisse]

Okay thanks for the explanation and great that i'm not the only one... and you could reproduce this...

please let me know if ican assist with some testing... or if you have some debug code that i should add too...

[Jefferson49]

Although there might be an explanation, I agree that the long delay time is not very pleasant. The implementation of GEDCOM tag ordering in webtrees might have some loops or is less efficient. It should not take so much time.

please let me know if ican assist with some testing... or if you have some debug code that i should add too...

At the moment, I have no good proposal for testing. Maybe, it would be interesting if simular times are consumed for other changes in webtrees or if the long time is only observed for Repository Hierarchie.

One idea might be to run some profiling with xdebug to see where the time is consumed. I have done this for other issues in the past. During profiling, all functions calls and the consumed times are recorded by xdebug. However, it is complicated to start. If you already have a debug environment with xdebug running, it might be interesting. If not, it is probably too much effort to install and get it running.

[Jefferson49]

Habe heute ein neues Custom Module webtrees-API veröffentlicht. Wenn Du Lust hast, hier mal reinzuschauen und zu testen, würde es mir helfen. Wenn API-Zugriffe (z.B. per Skript) nicht so Dein Betätigungsfeld sind, kannst Du Dir das API auch ganz gut in der Browser Oberfläche mit einem Swagger UI anschauen. Gerne auch per Email: jefferson49 (at) gmx.net

[HerzScheisse]

upps... gar nicht geantwortet... nee hab keine xdebug Umgebung laufen

hatte mich vor paar tagen schon gewundert... hatte das repo schonmal vor ner Weile entdeckt und dann wars auf einmal weg... :-)
ja kann ich mir gern mal anschauen... irgendwas bestimmtes was du getestet haben möchtest, oder nur ganz allgemein die Nutzung der API
Hab schon öfters mit APIs gespielt... unter anderem via postman für ein openhab modul und ich nutze ja schon Ewigkeiten openhab und daher kenne ich auch die Swagger UI... die ist da nämlich auch drin...

[Jefferson49]

irgendwas bestimmtes was du getestet haben möchtest, oder nur ganz allgemein die Nutzung der API

Erst einmal allgemein: Technical User anlegen, Swagger UI nutzen, Clients anlegen, Token generieren, APIs von extern aufrufen, ...

unter anderem via postman für ein openhab modul und ich nutze ja schon Ewigkeiten openhab

Postman passt perfekt. Webtrees wäre dann vmtl. ein vergleichbares Testobjekt wie openHAB ...