Skip to content

refactor(QADB): upgrade normalized-yield timelines#470

Open
c-dilks wants to merge 39 commits into
mainfrom
refactor-charge
Open

refactor(QADB): upgrade normalized-yield timelines#470
c-dilks wants to merge 39 commits into
mainfrom
refactor-charge

Conversation

@c-dilks

@c-dilks c-dilks commented Apr 24, 2026

Copy link
Copy Markdown
Member

This is the first QADB timeline to be refactored from the qa-physics/ code into the src/ code. It will pave the way for how to do the rest.

We will not get rid of the old QADB timeline production code, until everything is refactored.

For qtl histograms:

  • --focus-detectors will now additionally fill the new QADB histograms; if there are no scalers in the input file, a warning will just be printed (chefs may notify us devs if it happens, but this should not impact calibration timeline production)
  • developers may use the new option --focus-qadb for rapid testing, which will only fill the new QADB histograms

For qtl analysis:

  • if the QADB histograms were produced by qtl histogram, the new QADB timelines will also be produced; if not, a 'debug' message will be printed to stdout
  • developers may use the option -t qadb to restrict qtl analysis to the new QADB timelines only, for more rapid testing

@c-dilks
c-dilks force-pushed the refactor-charge branch from 3b4a82c to 13fcef9 Compare June 9, 2026 13:34
@c-dilks c-dilks changed the title refactor(QADB): upgrade charge timelines refactor(QADB): upgrade normalized-yield timelines Jun 9, 2026
@c-dilks
c-dilks force-pushed the refactor-charge branch 2 times, most recently from 8d2d0d7 to 7269d3b Compare July 16, 2026 15:20
@c-dilks

c-dilks commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

no diffs between timelines produced by this new code and from those from the old code

@c-dilks
c-dilks marked this pull request as ready for review July 19, 2026 01:24
@c-dilks

c-dilks commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

All right, I'm happy enough with this.

@Sangbaek, this is the beginning of a grand refactor of all the QADB production code from the qa-physics/ directory. Could you review the changes, in particular to higher-level parts of the code such as

  • run_histograms.java
  • run_analysis.groovy

Don't worry about all the newly added histogramming Java classes and analysis Groovy classes (in the new qadb/ subdirectories); I've cross checked the resulting timelines with the old ones, and there are no diffs.

@c-dilks
c-dilks requested a review from Sangbaek July 19, 2026 01:30
@c-dilks
c-dilks enabled auto-merge (squash) July 19, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant