refactor(QADB): upgrade normalized-yield timelines#470
Open
c-dilks wants to merge 39 commits into
Open
Conversation
c-dilks
force-pushed
the
refactor-charge
branch
2 times, most recently
from
July 16, 2026 15:20
8d2d0d7 to
7269d3b
Compare
Member
Author
|
no diffs between timelines produced by this new code and from those from the old code |
c-dilks
marked this pull request as ready for review
July 19, 2026 01:24
Member
Author
|
All right, I'm happy enough with this. @Sangbaek, this is the beginning of a grand refactor of all the QADB production code from the
Don't worry about all the newly added histogramming Java classes and analysis Groovy classes (in the new |
c-dilks
enabled auto-merge (squash)
July 19, 2026 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first QADB timeline to be refactored from the
qa-physics/code into thesrc/code. It will pave the way for how to do the rest.We will not get rid of the old QADB timeline production code, until everything is refactored.
For
qtl histograms:--focus-detectorswill now additionally fill the new QADB histograms; if there are no scalers in the input file, a warning will just be printed (chefs may notify us devs if it happens, but this should not impact calibration timeline production)--focus-qadbfor rapid testing, which will only fill the new QADB histogramsFor
qtl analysis:qtl histogram, the new QADB timelines will also be produced; if not, a 'debug' message will be printed tostdout-t qadbto restrictqtl analysisto the new QADB timelines only, for more rapid testing