Using pyflakes to check the code

Author: DraTeots

.github/workflows/cli-smoke.yml

@@ -82,10 +82,13 @@ jobs:
 
       - name: "Select with a query"
         run: |
-          # beam_current > 5 must match run 100 (12.5) and exclude run 101 (0.0)
-          OUT=$(rcdb select "beam_current > 5" 100-101)
+          # beam_current > 5 must match run 100 (12.5) and exclude run 101 (0.0).
+          # The third arg selects beam_current as a view column, so the actual
+          # VALUE must appear in the output - not just the run number.
+          OUT=$(rcdb select "beam_current > 5" 100-101 beam_current)
           echo "$OUT"
           echo "$OUT" | grep -q "100"
+          echo "$OUT" | grep -q "12.5"   # value column must be populated, not empty
           if echo "$OUT" | grep -qw "101"; then
             echo "ERROR: run 101 (beam_current=0.0) should not match 'beam_current > 5'"
             exit 1

.github/workflows/lint-pyflakes.yml

@@ -0,0 +1,40 @@
+name: Lint (pyflakes)
+
+# Informational only: runs pyflakes over the Python sources and prints the
+# findings, but never fails the build. The codebase has known pre-existing
+# findings, plus false positives from intentional __init__.py re-exports and
+# `from rcdb.model import *`. Use this report to spot newly introduced unused
+# imports / undefined names in a pull request diff.
+
+on:
+  push:
+    branches: ["*"]
+  pull_request:
+    branches: [main]
+
+jobs:
+  pyflakes:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Set up Python
+        uses: actions/setup-python@v6
+        with:
+          python-version: "3.12"
+
+      # pyflakes is declared in the project's `dev` optional-dependency group,
+      # so the CI and local developers use the same version.
+      - name: Install pyflakes
+        run: |
+          python -m pip install --upgrade pip
+          pip install "$GITHUB_WORKSPACE/python[dev]"
+
+      - name: Run pyflakes (informational, never fails)
+        run: |
+          # This is a report, not a gate: always exit 0.
+          pyflakes python/rcdb python/daq > pyflakes.txt 2>&1 || true
+          cat pyflakes.txt
+          echo "--------------------------------------------------"
+          echo "pyflakes findings: $(wc -l < pyflakes.txt)"