Fix pyflake warnings and make it mandatory

Author: DraTeots

.github/workflows/lint-pyflakes.yml

@@ -1,10 +1,9 @@
 name: Lint (pyflakes)
 
-# Informational only: runs pyflakes over the Python sources and prints the
-# findings, but never fails the build. The codebase has known pre-existing
-# findings, plus false positives from intentional __init__.py re-exports and
-# `from rcdb.model import *`. Use this report to spot newly introduced unused
-# imports / undefined names in a pull request diff.
+# Mandatory gate: runs pyflakes over the Python sources and FAILS the build on
+# any finding (unused imports, undefined names, dead locals, format bugs, ...).
+# The codebase is pyflakes-clean; intentional re-exports use explicit imports
+# plus `__all__`, so there are no false positives to suppress.
 
 on:
   push:
@@ -31,10 +30,7 @@ jobs:
           python -m pip install --upgrade pip
           pip install "$GITHUB_WORKSPACE/python[dev]"
 
-      - name: Run pyflakes (informational, never fails)
+      - name: Run pyflakes (fails on any finding)
+        working-directory: python
         run: |
-          # This is a report, not a gate: always exit 0.
-          pyflakes python/rcdb python/daq > pyflakes.txt 2>&1 || true
-          cat pyflakes.txt
-          echo "--------------------------------------------------"
-          echo "pyflakes findings: $(wc -l < pyflakes.txt)"
+          pyflakes rcdb daq halld_rcdb tests utilities examples

docs/development/development.md

@@ -31,6 +31,35 @@ Both suites run on GitHub CI (`.github/workflows/python-tests.yml` and
 for more detail.
 
 
+## Linting (pyflakes)
+
+The Python sources are kept **pyflakes-clean**. Pyflakes catches unused imports,
+undefined names, dead local variables and `str.format`/f-string mistakes.
+
+`pyflakes` ships in the project's `dev` optional-dependency group. From the
+`python/` directory:
+
+```bash
+# one-off, without installing the dev group into your environment:
+uv run --extra dev pyflakes rcdb daq halld_rcdb tests utilities examples
+
+# or, if you installed the project with the dev extra (pip install -e ".[dev]"):
+pyflakes rcdb daq halld_rcdb tests utilities examples
+```
+
+The command must print nothing and exit `0`. This is a **mandatory CI gate**
+(`.github/workflows/lint-pyflakes.yml`): any finding fails the build, so run it
+before pushing.
+
+A couple of conventions keep it clean without `# noqa` suppressions:
+
+- **Intentional re-exports** (e.g. `rcdb/__init__.py`,
+  `rcdb/web/modules/__init__.py`) use explicit imports plus an `__all__` list
+  instead of relying on `import *`.
+- Prefer explicit imports over `from module import *` so undefined-name checks
+  keep working.
+
+
 ## Multi-Database Selector
 
 The web interface supports switching between multiple databases from the browser.

python/daq/update_epics.py

@@ -433,7 +433,6 @@ def setup_run_conds(run):
 def update_rcdb_conds(db, run, reason):
     log.debug(Lf("Running 'update_rcdb_conds(db={},   run={})'", db, run))
 
-    TOLERANCE = 1.e-5  # constant used for comparisons
     # Run can be a rcdb.Run object or a run number
     if not isinstance(run, Run):
         log.debug(Lf("Getting run by number={}", run))

python/halld_rcdb/run_config_parser.py

@@ -81,7 +81,7 @@ def _process_parse_result(parse_result, file_name=""):
         if 'FADC125_MODE' in cdc_section.entities:
             try:
                 result.cdc_fadc125_mode = int(cdc_section.entities['FADC125_MODE'])
-            except ValueError as ex:
+            except ValueError:
                 log.warning(F("Cant convert CDC:FADC125_MODE value '{}' to int", cdc_section.entities['FADC125_MODE']))
     else:
         log.warning(F("CDC section is not found in '{}'", file_name))

python/rcdb/cli/add.py

@@ -48,7 +48,7 @@ def add_type(context, name, value_type, description):
 
     # Create or verify
     click.echo(f"Creating condition type '{name}' of type '{value_type}'")
-    ct = db.create_condition_type(name, actual_type, description)
+    db.create_condition_type(name, actual_type, description)
     click.echo("Done.")
 
 

python/rcdb/cli/db.py

@@ -80,7 +80,7 @@ def _print_sqlite_table_sizes(engine):
             size_mb = round(total_bytes / 1024 / 1024, 2)
             click.echo(f"  {table_name:30} {size_mb} MB")
 
-    except Exception as ex:
+    except Exception:
         click.echo("\n No table size info: sqlite dbstat extension is not installed. Use sqlite3_analyzer to get table sizes")
 
 
@@ -116,8 +116,6 @@ def update(context):
     if not click.confirm('Do you really want to continue?'):
         return
 
-    # That we will need for DB
-    metadata = rcdb.model.Base.metadata
     provider = RCDBProvider(context.connection_str, check_version=False)
 
     # Create alias table

python/rcdb/cli/info.py

@@ -54,6 +54,5 @@ def info_command(context):
         click.echo(f"  End Date:    {last_rp.end_date}")
 
     # Finally, show all possible commands (help):
-    ctx = click.get_current_context()
     click.echo("\nrun 'rcdb --help' for the list of available commands")
 

python/rcdb/cli/repair/evio_files.py

@@ -29,7 +29,7 @@ def read_run_directories(mask, run_min, run_max):
         run_dir_name = path.basename(run_dir)
         try:
             run_num = int(run_dir_name[3:])
-        except Exception as ex:
+        except Exception:
             click.echo(f"Error extracting run from directory '{run_dir_name}'")
             continue
 

python/rcdb/condition_query_builder.py

@@ -27,6 +27,7 @@ def restart(self):
         result = self.elapsed
         self.reset()
         self.start()
+        return result
 
     def reset(self):
         self._start = None