feat: use logical camera names rather than ids#15
Open
kagenihisomi wants to merge 2 commits into
Open
Conversation
- Introduced CameraEnumerator class to enumerate available cameras and retrieve their names. - Updated CameraConfig to use camera names instead of IDs. - Modified CameraStream to support starting a camera by name. - Enhanced CameraSettingsWindow to populate camera options from available cameras. - Updated UI components to reflect changes in camera selection. - Added a manual test script for camera enumeration functionality.
Owner
|
I will check your code tomorrow or the day after tomorrow. |
Jeka8833
requested changes
Feb 10, 2026
Owner
Jeka8833
left a comment
Jeka8833
left a comment
There was a problem hiding this comment.
At this point, I cannot approve your code because it does not function well.
Problems:
- When the program is launched (the user did not press any buttons), the video stream does not start automatically. To start the video stream, the user needs to select another webcam from the list.
- When you open Camera Settings, all existing video streams are terminated and you are left without a webcam.
- Some video cameras are not displayed in the list (this is the most critical issue for me). I have attached how many cameras FoxyFace sees and how many cameras OBS sees. I suspect that cameras from Microsoft Media Foundation are not displayed. I would also like to clarify that simple access by index works (i.e., OpenCV sees the camera and can open the video stream).
If you cannot reproduce the problems or do not understand them, please let me know.
I also suspect that the code was written with the help of some AI agents, as there are many comments and even tests. If I am wrong, I apologize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using camera id is really difficult, spend 20 minutes wondering why OBS virtual Camera never showed, turns out depending on devices it moves up and down with no deterministic way,
This makes it easier to select (albeit opening settings menu takes 1-2 seconds now)
Settings
Show cameras