Better with attribute#548
Draft
fredszaq wants to merge 6 commits into
Draft
Conversation
694af23 to
d24745a
Compare
d24745a to
603d92d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #535, (I will mark this PR as non-draft once #535 is merged; for now, you will see changes from both PRs in the diff). The actual changes are in this commit d24745a.
Synopsis
Allow
withatribute to containsyn::ExprCallandsyn::ExprClosurein addition tosyn::PathSolution
This uses the same approach as what was done for the
#[from_str(error(...))]. I extracted the type used to parse the content of the attribute to one namedCallable.Checklist