fix(mcp): break circular dependency between keyword.types and council-preset.service

Extract CouncilPreset interface and CouncilMode type to a dedicated
council-preset.types.ts file that has no imports from keyword module.
Both keyword.types.ts and council-preset.service.ts now import from
the shared types file, eliminating the cycle.

- keyword.types.ts → council-preset.types.ts (no cycle)
- council-preset.service.ts → council-preset.types.ts (no cycle)
- council-preset.service.ts re-exports CouncilPreset for API compat

Author: JeremyDev87

apps/mcp-server/src/agent/council-preset.service.ts

@@ -1,16 +1,7 @@
 import { Injectable } from '@nestjs/common';
-import type { Mode } from '../keyword/keyword.types';
+import type { CouncilMode, CouncilPreset } from './council-preset.types';
 
-/**
- * A deterministic council preset: a primary agent plus specialist reviewers
- */
-export interface CouncilPreset {
-  mode: 'PLAN' | 'EVAL';
-  primary: string;
-  specialists: string[];
-}
-
-type CouncilMode = Extract<Mode, 'PLAN' | 'EVAL'>;
+export type { CouncilPreset } from './council-preset.types';
 
 const COUNCIL_PRESETS: Record<CouncilMode, CouncilPreset> = {
   PLAN: {
@@ -36,7 +27,7 @@ export class CouncilPresetService {
    * Resolve the council preset for a given mode.
    * Returns null for modes without a preset (ACT, AUTO).
    */
-  resolvePreset(mode: Mode): CouncilPreset | null {
+  resolvePreset(mode: string): CouncilPreset | null {
     const preset = COUNCIL_PRESETS[mode as CouncilMode];
     if (!preset) return null;
     return { ...preset, specialists: [...preset.specialists] };

apps/mcp-server/src/agent/council-preset.types.ts

@@ -0,0 +1,16 @@
+/**
+ * Council Preset Types — extracted to break circular dependency
+ * between keyword.types and council-preset.service.
+ */
+
+/** Modes that support council presets */
+export type CouncilMode = 'PLAN' | 'EVAL';
+
+/**
+ * A deterministic council preset: a primary agent plus specialist reviewers.
+ */
+export interface CouncilPreset {
+  mode: CouncilMode;
+  primary: string;
+  specialists: string[];
+}

apps/mcp-server/src/keyword/keyword.types.ts

@@ -1,5 +1,5 @@
 import type { DiffAnalysisResult } from './diff-analyzer';
-import type { CouncilPreset } from '../agent/council-preset.service';
+import type { CouncilPreset } from '../agent/council-preset.types';
 import type { CouncilSummary } from '../collaboration/council-summary.types';
 
 export const KEYWORDS = ['PLAN', 'ACT', 'EVAL', 'AUTO'] as const;