fix(mcp): resolve CI failures for diff-based agent recommendation

- Add import type for DiffAnalysisResult in keyword.types.ts (TS2304)
- Remove unused type imports in diff-analyzer.spec.ts (lint error)
- Apply prettier formatting

Author: JeremyDev87

apps/mcp-server/src/keyword/diff-analyzer.spec.ts

@@ -1,10 +1,4 @@
-import {
-  analyzeDiffFiles,
-  getDiffFiles,
-  DIFF_FILE_PATTERNS,
-  type DiffAnalysisResult,
-  type DiffAgentScore,
-} from './diff-analyzer';
+import { analyzeDiffFiles, getDiffFiles, DIFF_FILE_PATTERNS } from './diff-analyzer';
 
 describe('diff-analyzer', () => {
   describe('DIFF_FILE_PATTERNS', () => {
@@ -34,20 +28,14 @@ describe('diff-analyzer', () => {
     });
 
     it('should boost test-engineer for .test.ts files', () => {
-      const result = analyzeDiffFiles([
-        'src/auth/login.test.ts',
-        'src/auth/login.spec.ts',
-      ]);
+      const result = analyzeDiffFiles(['src/auth/login.test.ts', 'src/auth/login.spec.ts']);
       expect(result.topAgent).not.toBeNull();
       expect(result.topAgent!.agent).toBe('test-engineer');
       expect(result.topAgent!.matchedFiles.length).toBe(2);
     });
 
     it('should boost devops-engineer for Dockerfile and .github/ files', () => {
-      const result = analyzeDiffFiles([
-        'Dockerfile',
-        '.github/workflows/ci.yml',
-      ]);
+      const result = analyzeDiffFiles(['Dockerfile', '.github/workflows/ci.yml']);
       expect(result.topAgent).not.toBeNull();
       expect(result.topAgent!.agent).toBe('devops-engineer');
     });
@@ -63,28 +51,19 @@ describe('diff-analyzer', () => {
     });
 
     it('should boost backend-developer for .py files', () => {
-      const result = analyzeDiffFiles([
-        'hooks/pre-commit.py',
-        'scripts/deploy.py',
-      ]);
+      const result = analyzeDiffFiles(['hooks/pre-commit.py', 'scripts/deploy.py']);
       expect(result.topAgent).not.toBeNull();
       expect(result.topAgent!.agent).toBe('backend-developer');
     });
 
     it('should boost platform-engineer for .tf files', () => {
-      const result = analyzeDiffFiles([
-        'infra/main.tf',
-        'infra/variables.tf',
-      ]);
+      const result = analyzeDiffFiles(['infra/main.tf', 'infra/variables.tf']);
       expect(result.topAgent).not.toBeNull();
       expect(result.topAgent!.agent).toBe('platform-engineer');
     });
 
     it('should boost data-engineer for .sql and migration files', () => {
-      const result = analyzeDiffFiles([
-        'migrations/001_create_users.sql',
-        'schema.prisma',
-      ]);
+      const result = analyzeDiffFiles(['migrations/001_create_users.sql', 'schema.prisma']);
       expect(result.topAgent).not.toBeNull();
       expect(result.topAgent!.agent).toBe('data-engineer');
     });
@@ -121,9 +100,7 @@ describe('diff-analyzer', () => {
       ]);
       expect(result.scores.length).toBeGreaterThan(0);
       for (let i = 1; i < result.scores.length; i++) {
-        expect(result.scores[i - 1].score).toBeGreaterThanOrEqual(
-          result.scores[i].score,
-        );
+        expect(result.scores[i - 1].score).toBeGreaterThanOrEqual(result.scores[i].score);
       }
     });
 
@@ -152,16 +129,10 @@ describe('diff-analyzer', () => {
         'src/components/Header.tsx',
         'README.md', // no match
       ]);
-      const frontendScore = result.scores.find(
-        (s) => s.agent === 'frontend-developer',
-      );
+      const frontendScore = result.scores.find(s => s.agent === 'frontend-developer');
       expect(frontendScore).toBeDefined();
-      expect(frontendScore!.matchedFiles).toContain(
-        'src/components/Button.tsx',
-      );
-      expect(frontendScore!.matchedFiles).toContain(
-        'src/components/Header.tsx',
-      );
+      expect(frontendScore!.matchedFiles).toContain('src/components/Button.tsx');
+      expect(frontendScore!.matchedFiles).toContain('src/components/Header.tsx');
       expect(frontendScore!.matchedFiles).not.toContain('README.md');
     });
   });

apps/mcp-server/src/keyword/diff-analyzer.ts

@@ -146,10 +146,7 @@ export function analyzeDiffFiles(files: string[]): DiffAnalysisResult {
   }
 
   // Accumulate scores per agent
-  const agentAccumulator = new Map<
-    string,
-    { totalWeight: number; matchedFiles: string[] }
-  >();
+  const agentAccumulator = new Map<string, { totalWeight: number; matchedFiles: string[] }>();
 
   for (const file of files) {
     for (const { pattern, agent, weight } of DIFF_FILE_PATTERNS) {
@@ -232,7 +229,7 @@ function execGitDiff(args: string[], cwd: string): Promise<string[]> {
       const files = stdout
         .trim()
         .split('\n')
-        .filter((line) => line.length > 0);
+        .filter(line => line.length > 0);
       resolve(files);
     });
   });

apps/mcp-server/src/keyword/keyword.types.ts

@@ -1,3 +1,5 @@
+import type { DiffAnalysisResult } from './diff-analyzer';
+
 export const KEYWORDS = ['PLAN', 'ACT', 'EVAL', 'AUTO'] as const;
 
 export type Mode = (typeof KEYWORDS)[number];
@@ -550,7 +552,7 @@ export interface VisualData {
 }
 
 /** Re-export DiffAnalysisResult for consumers */
-export type { DiffAnalysisResult } from './diff-analyzer';
+export type { DiffAnalysisResult, DiffAgentScore } from './diff-analyzer';
 
 export interface ModeConfig {
   description: string;

apps/mcp-server/src/keyword/strategies/act-agent.strategy.ts

@@ -206,12 +206,7 @@ export class ActAgentStrategy implements ResolutionStrategy {
       if (availableAgents.includes(diffAgent) && score >= 0.4) {
         const confidence = Math.min(0.75, 0.5 + score * 0.25);
         this.logger.debug(`Diff-based agent: ${diffAgent} (score: ${score.toFixed(2)})`);
-        return createResult(
-          diffAgent,
-          'context',
-          confidence,
-          `Diff analysis: ${reason}`,
-        );
+        return createResult(diffAgent, 'context', confidence, `Diff analysis: ${reason}`);
       }
     }