fix(impact): add ImpactEventService mock to integration and service specs

Add missing mockImpactEventService to handler constructor calls in:
- abstract-handler.integration.spec.ts (4 type errors)
- mcp.service.spec.ts (4 type errors)

Fixes CI type-check failure from PR review.

Author: JeremyDev87

apps/mcp-server/src/mcp/handlers/abstract-handler.integration.spec.ts

@@ -19,6 +19,7 @@ import { ModelResolverService } from '../../model/model-resolver.service';
 import { StateService } from '../../state/state.service';
 import { ContextDocumentService } from '../../context/context-document.service';
 import { DiagnosticLogService } from '../../diagnostic/diagnostic-log.service';
+import type { ImpactEventService } from '../../impact';
 
 /**
  * Integration tests verifying all concrete handlers inherit
@@ -138,9 +139,15 @@ describe('Handler Security Integration', () => {
       error: vi.fn().mockResolvedValue({ success: true }),
     } as unknown as DiagnosticLogService;
 
+    const mockImpactEventService = { logEvent: vi.fn() } as unknown as ImpactEventService;
+
     // Initialize handlers
-    agentHandler = new AgentHandler(mockAgentService);
-    checklistHandler = new ChecklistContextHandler(mockChecklistService, mockContextService);
+    agentHandler = new AgentHandler(mockAgentService, mockImpactEventService);
+    checklistHandler = new ChecklistContextHandler(
+      mockChecklistService,
+      mockContextService,
+      mockImpactEventService,
+    );
     configHandler = new ConfigHandler(
       mockConfigService,
       mockConfigDiffService,
@@ -160,8 +167,13 @@ describe('Handler Security Integration', () => {
       mockContextDocService,
       mockDiagnosticLogService,
       mockAgentServiceForMode as AgentService,
+      mockImpactEventService,
+    );
+    rulesHandler = new RulesHandler(
+      mockRulesService,
+      mockModelResolverService,
+      mockImpactEventService,
     );
-    rulesHandler = new RulesHandler(mockRulesService, mockModelResolverService);
     skillHandler = new SkillHandler(mockSkillRecommendationService, mockRulesService);
   });
 

apps/mcp-server/src/mcp/mcp.service.spec.ts

@@ -17,6 +17,7 @@ import { ContextDocumentService } from '../context/context-document.service';
 import { ModelResolverService } from '../model';
 import { StateService } from '../state/state.service';
 import { DiagnosticLogService } from '../diagnostic/diagnostic-log.service';
+import type { ImpactEventService } from '../impact';
 import type { ToolHandler } from './handlers';
 import {
   RulesHandler,
@@ -450,6 +451,7 @@ interface CreateMcpServiceOptions {
   modelResolverService?: Partial<ModelResolverService>;
   stateService?: Partial<StateService>;
   diagnosticLogService?: Partial<DiagnosticLogService>;
+  impactEventService?: Partial<ImpactEventService>;
 }
 
 function createMcpServiceWithHandlers(
@@ -462,6 +464,7 @@ function createMcpServiceWithHandlers(
     new RulesHandler(
       services.rulesService as RulesService,
       services.modelResolverService as ModelResolverService,
+      services.impactEventService as ImpactEventService,
     ),
     new ConfigHandler(
       services.configService as ConfigService,
@@ -472,7 +475,10 @@ function createMcpServiceWithHandlers(
       services.skillRecommendationService as SkillRecommendationService,
       services.rulesService as RulesService,
     ),
-    new AgentHandler(services.agentService as AgentService),
+    new AgentHandler(
+      services.agentService as AgentService,
+      services.impactEventService as ImpactEventService,
+    ),
     new ModeHandler(
       services.keywordService as KeywordService,
       services.configService as ConfigService,
@@ -482,10 +488,12 @@ function createMcpServiceWithHandlers(
       services.contextDocService as ContextDocumentService,
       services.diagnosticLogService as DiagnosticLogService,
       services.agentService as AgentService,
+      services.impactEventService as ImpactEventService,
     ),
     new ChecklistContextHandler(
       services.checklistService as ChecklistService,
       services.contextService as ContextService,
+      services.impactEventService as ImpactEventService,
     ),
   ];
 
@@ -573,6 +581,7 @@ describe('McpService', () => {
       modelResolverService: mockModelResolverService,
       stateService: mockStateService,
       diagnosticLogService: mockDiagnosticLogService,
+      impactEventService: { logEvent: vi.fn() },
     };
 
     const mcpService = createMcpServiceWithHandlers(defaultMocks);