feat(plugin): add mini bar chart visualization to session summary (#1041)#1055
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Mar 28, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Conductor Code Review — #1041 Bar Chart Visualization
✅ Good
render_bar_chart()is a clean pure function with proper ASCII fallback- Edge cases handled well (zero value, zero max, value exceeds max)
- Color mapping by tool type is a nice touch
- Test coverage is solid (12 test cases for render_bar_chart, 5 for integration)
- ASCII mode integration with existing
buddy.asciiModeconfig — consistent
⚠️ Suggestions (address these)
-
_render_bar_chartsonly shows tool distribution, not file changes or tests- Issue spec says: "Tool call count + distribution, Files changed, Test count"
- Currently only tool distribution bars are rendered
- Add a bar for files_changed and tests if available in stats
-
render_session_summarysignature —tool_namesparameter- How is
tool_namesdict populated? The stop.py doesn't seem to pass it. - Verify the caller actually provides this data, otherwise bars will never appear.
- How is
-
Magic number
width=20- Issue spec says "bar width auto-adjusts to terminal width"
- Currently hardcoded to 20. Consider reading
os.get_terminal_size().columnswith fallback.
-
Label width
{label:<12}is hardcoded- If tool name exceeds 12 chars (e.g., "NotebookEdit"), it won't align properly.
- Consider computing max label width dynamically from the data.
📝 Minor
- Top 3 tools limit is reasonable but could be configurable
Verdict
Address items 1-2 (spec compliance + caller integration). Items 3-4 are nice-to-have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_bar_chart()pure function with Unicode/ASCII/color supportbuddy.asciiMode)Example output:
Test plan
render_bar_chart()(full/half/zero/max/ASCII/color)render_session_summary()yarn workspace codingbuddy test— 5308 passedyarn workspace codingbuddy-claude-plugin test— 71 passedCloses #1041