feat(plugin): define mode-specific Tiny Actor cast presets (#1272)#1284
Merged
Conversation
Add deterministic cast presets for PLAN, EVAL, AUTO, and SHIP modes with Buddy moderator copy. Each preset maps a primary agent and specialist list from real .ai-rules agent definitions.
JeremyDev87
added
feat
plugin
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE ✅ (CI 1 pending — will confirm after full pass)
CI Status: 27/28 pass, 1 pending
Code Quality
CastPresetTypedDict with primary, specialists, moderator_copy- 4 modes: PLAN, EVAL, AUTO, SHIP (SHIP instead of ACT — better fit for council)
get_cast_preset(mode)returns preset or Noneget_moderator_copy(mode)with default fallbackBUDDY_FACEconstant: ◕‿◕- All agent IDs reference real
.ai-rules/agents/*.jsonnames
Tests (206 lines, 10 test classes)
- Valid/unknown mode handling
- Required keys presence
- Determinism verification
- Kebab-case agent ID format validation
- Agent JSON file cross-reference (skipif agents dir not found)
- Display budget (moderator copy <= 40 chars)
- CAST_PRESETS dict integrity (no extra modes)
No Issues Found
- Clean TypedDict usage
- Sensible moderator copy messages
Recommendation: APPROVE (pending CI full pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAST_PRESETSdict with deterministic cast for PLAN, EVAL, AUTO, SHIP modes.ai-rules/agents/*.jsondefinitionsget_cast_preset(mode)andget_moderator_copy(mode)lookup functionsTest plan
yarn test:hooks— 563 tests passedyarn workspace codingbuddy build— successCloses #1272