Skip to content

feat(plugin): implement width-safe Tiny Actor card renderer (#1269)#1292

Merged
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775269110/pane-1
Apr 4, 2026
Merged

feat(plugin): implement width-safe Tiny Actor card renderer (#1269)#1292
JeremyDev87 merged 1 commit into
masterfrom
taskmaestro/1775269110/pane-1

Conversation

@JeremyDev87

Copy link
Copy Markdown
Owner

Summary

  • Add render_card() in hooks/lib/tiny_actor_renderer.py — compact 2-3 line card renderer using display-width-safe helpers
  • Every output line is guaranteed to have exactly card_width display columns
  • Handles CJK text truncation, ANSI-colored faces, and ASCII mode without visual drift

Test plan

  • 16 unit tests in tests/test_tiny_actor_renderer.py
  • Basic rendering (2-line, 3-line, show_quote=False)
  • Display-width safety (all lines equal width at 6/14/20 cols)
  • CJK truncation (Korean, Japanese labels and quotes)
  • ANSI-colored face alignment
  • ASCII mode produces only ASCII
  • Content correctness (face/label/quote in expected lines)

Closes #1269

Add render_card() that produces compact 2-3 line cards using
display-width-safe helpers from buddy_renderer. Handles CJK text,
ANSI-colored faces, and ASCII mode without visual drift.
@JeremyDev87 JeremyDev87 added feat plugin packages/claude-code-plugin wow-experience Plugin Wow Experience Design labels Apr 4, 2026
@vercel

vercel Bot commented Apr 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codingbuddy-landing Building Building Preview, Comment Apr 4, 2026 2:25am

@JeremyDev87 JeremyDev87 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE ✅ (CI pending — will confirm after full pass)

CI Status: 5/28 pass, 23 pending

Code Quality

  • render_card() produces 2-3 lines at exact card_width display columns
  • _center_to_width() helper: left-pad + right-pad with display-width awareness
  • Uses pad_to_display_width and truncate_to_display_width from buddy_renderer
  • Import from tiny_actor_card for TinyActorCard type

Tests (205 lines, 6 classes)

  • Basic: 3 lines with quote, 2 without, show_quote=False
  • Display-width safety: all lines exact width at 14/20/6 cols
  • CJK: Korean + Japanese labels truncated correctly
  • ANSI: colored faces don't break width
  • ASCII mode: no unicode in output
  • Content: face centered, label present

No Issues Found

Recommendation: APPROVE (pending CI full pass)

@JeremyDev87 JeremyDev87 self-assigned this Apr 4, 2026
@JeremyDev87 JeremyDev87 merged commit d28d102 into master Apr 4, 2026
27 of 28 checks passed
@JeremyDev87 JeremyDev87 deleted the taskmaestro/1775269110/pane-1 branch April 4, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat plugin packages/claude-code-plugin wow-experience Plugin Wow Experience Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(plugin): implement a width-safe Tiny Actor card renderer using display-width helpers

1 participant