fix(plugin): make Tiny Actor Grid layout display-width-safe for CJK/ANSI (#1304)#1306
Merged
Merged
Conversation
…NSI (#1304) Replace ljust() with pad_to_display_width() in layout_grid() so multi-column rows stay visually aligned with CJK labels, emoji, and ANSI-colored content.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Quality:
- tiny_actor_grid.py: Replaced
ljust(card_width)withpad_to_display_width(part, card_width)— surgical 1-line fix - test_tiny_actor_grid.py: 3 new tests — CJK labels, ANSI colored text, mixed CJK/ANSI/ASCII grids
- All tests verify uniform
display_width()across output lines - Korean text (
한국어,보안전문가) and ANSI escape codes tested explicitly
✅ Grid layout now truly display-width-safe for CJK and ANSI text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str.ljust()withpad_to_display_width()inlayout_grid()so multi-column Tiny Actor rows stay visually aligned with CJK, emoji, and ANSI-colored contentdisplay_widthandpad_to_display_widthfrombuddy_rendererin the grid moduleTest plan
python3 -m pytest tests/test_tiny_actor_grid.py -v)tsc --noEmit)Closes #1304