feat(plugin): derive Tiny Actor faces from agent visual.eye metadata (#1301)#1316
Merged
Conversation
…1301) Load real visual.eye glyphs from agent JSON definitions into Tiny Actor cards instead of using the generic default glyph. Buddy moderator keeps its hardcoded identity. Falls back gracefully for missing/malformed agents.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 4, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: ✅ APPROVE
CI Status: ALL PASS
Code Quality:
- _load_agent_eye(): Clean JSON loader with safe fallback — reads
.ai-rules/agents/<id>.json, extractsvisual.eye - Path resolution:
_AGENTS_DIRcomputed relative to file location - Integration:
eye_glyph=_load_agent_eye(...)passed to both primary and specialistcreate_actor_card()calls - Buddy unchanged: Moderator still uses hardcoded BUDDY_FACE
- Tests: 9 new tests — known agent, unknown agent, malformed JSON, missing visual block, empty eye, buddy moderator, specialist real glyph, all modes
Safety:
- All failures silently return None (generic fallback)
- No import changes to existing callers
- Feature flag still respected
✅ Tiny Actor cards now show real per-agent persona glyphs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visual.eyeglyphs from agent JSON definitions (packages/rules/.ai-rules/agents/*.json) into Tiny Actor specialist cards_load_agent_eye()helper that resolves agent ID to JSON file and readsvisual.eyefield●◕identityvisualblockTest plan
visual.eyeglyphNone(default glyph)visualblock returnsNoneNone◕‿◕faceCloses #1301