feat(plugin): add council UX fields to HUD/state model (#1364)

[JeremyDev87]

Summary

• Add councilActive (bool), councilStage (str), councilCast (list) fields to hud_state.py defaults and init_hud_state()
• Add on_council_update() helper to hud_helpers.py for start/advance/end council semantics
• Reset council fields on mode entry (on_mode_entry) and session stop (on_session_stop)
• Backward compatible: fill_defaults=True back-fills council fields for older state files

Test plan

• TestCouncilFields — init defaults, update active/stage/cast, full lifecycle, fill_defaults
• TestOnCouncilUpdate — start, advance stage, end council, no-op on empty args
• TestOnModeEntry.test_resets_all_stale_workflow_fields — council fields reset on mode entry
• TestOnSessionStop.test_clears_agent_and_sets_completed — council fields cleared on stop
• TestFullLifecycle.test_session_lifecycle — council activity through complete session lifecycle
• All 24 hud_state tests pass, all 57 hud_helpers tests pass
• MCP server: 6134 tests pass, build succeeds

Closes #1364

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
codingbuddy-landing	Ready	Preview, Comment	Apr 6, 2026 11:09am

[JeremyDev87]

Review: APPROVE

CI Status: PASS

All 28 checks passed (lint, typecheck, build, tests, security, format, circular, e2e).

Code Quality

• Clean diff: 4 files changed, well-scoped to HUD state model extension
• No unused imports: List import properly used by on_council_update parameter
• No any types: All fields explicitly typed
• Consistent patterns: on_council_update follows existing on_mode_entry/on_session_stop structure (try/except pass, kwargs-based updates)
• No dead code

Spec Compliance (Issue #1364)

All acceptance criteria met:

• ✅ councilActive, councilStage, councilCast fields added to HUD state model
• ✅ Defaults in _EXTENDED_DEFAULTS and init_hud_state
• ✅ on_council_update() helper with partial-update semantics
• ✅ Mode entry and session stop reset council fields intentionally
• ✅ Tests cover initialization, updates, reset, and fill_defaults backward compat

Test Coverage

• 7 new TestCouncilFields tests (state layer)
• 4 new TestOnCouncilUpdate tests (helper layer)
• Existing reset/lifecycle tests extended with council assertions
• Edge cases: no-arg noop, fill_defaults preservation, stage advancement with field preservation

Issues Found

None.

Recommendation: APPROVE

[JeremyDev87]

✅ Review complete - review agent approved

Review Summary

• CI: All checks reviewed
• Code Quality: No issues found
• Spec Compliance: Matches #1364 requirements
• Test Coverage: Adequate

LGTM - ready to merge.