feat(plugin): seed request-level council state from UserPromptSubmit (#1361)#1416
Merged
Conversation
…1361) When entering PLAN, EVAL, or AUTO mode, UserPromptSubmit now seeds council HUD state (councilActive, councilStage, councilCast) so downstream surfaces can render a first-scene immediately. - MCP mode: uses COUNCIL_PRESETS from mode_engine - Standalone mode: uses CAST_PRESETS from tiny_actor_presets - ACT mode: council remains inactive (compact/opt-in)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 6, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status: PASS (29/29, including e2e-plugin-docker and e2e-plugin-hooks)
Spec Compliance (#1361)
All 3 acceptance criteria met:
- ✅ Request-driven council state seeded on PLAN/EVAL/AUTO prompts (
_COUNCIL_ELIGIBLE_MODES) - ✅ MCP mode uses
COUNCIL_PRESETS, standalone usesCAST_PRESETSwith defensive fallback - ✅ ACT mode does not create council state; no preset → council inactive
Code Quality
council_preset: Optional[Dict] = None— backward-compatible API extension- Atomic reset-then-seed: council fields first reset to empty, then conditionally overwritten
- Cast construction:
[primary] + list(specialists)with empty-primary guard - Defensive standalone fallback:
CAST_PRESETSimport failure →COUNCIL_PRESETS - Exception handling follows existing hook resilience patterns
Test Coverage: 12 new tests
Unit (7):
- PLAN/EVAL/AUTO mode seeds council with preset
- ACT mode does NOT seed even with preset
- No preset keeps council inactive
- Cast includes primary + specialists in correct order
- Reset-then-seed replaces old state
Integration (5):
- PLAN standalone seeds council (primary=technical-planner)
- PLAN MCP seeds council (primary=technical-planner)
- ACT does not seed council
- EVAL seeds council (primary=code-reviewer)
- AUTO seeds council (primary=auto-mode)
Issues Found: 0
No Critical, High, Medium, or Low issues found.
Recommendation: APPROVE
JeremyDev87
commented
Apr 6, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Review complete - review agent approved. Issues: 0.
JeremyDev87
added
feat
plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserPromptSubmit에서 council HUD state를 즉시 시딩COUNCIL_PRESETS사용 (mode_engine.py)CAST_PRESETSfallback (tiny_actor_presets.py)Changes
hud_helpers.py:on_mode_entry()에council_preset파라미터 추가, 적격 모드에서councilActive=True,councilStage="opening",councilCast=[primary, ...specialists]시딩user-prompt-submit.py: MCP/standalone 판단 후 적절한 preset을on_mode_entry()에 전달test_hud_helpers.py: 7개 unit test 추가 (seeding, ACT 제외, preset 없음 처리, reset-then-seed)test_user_prompt_submit.py: 5개 integration test 추가 (MCP/standalone/ACT/EVAL/AUTO)Test plan
python3 -m pytest tests/test_hud_helpers.py— 64 passedpython3 -m pytest test_user_prompt_submit.py— 92 passedyarn workspace codingbuddy test— 6157 passedyarn workspace codingbuddy build— successCloses #1361