feat(mcp-server): make Discover→Design→Plan a real staged default (#1420)#1428
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
) Change default routing so clear prompts start at discover instead of skipping directly to plan. Users advance through stages by passing the planning_stage parameter (discover → design → plan). - resolveStage() now defaults to 'discover' for all non-hinted calls - stageHint override preserved: callers can still force any stage - Added stageProgression metadata (completedStages, currentStage, remainingStages) - Updated unit tests for new default behavior (28 pass) - Updated mode.handler integration tests (122 pass) - Full test suite: 6190 pass, 0 fail
983c4f8 to
ca87234
Compare
JeremyDev87
commented
Apr 7, 2026
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status: ALL PASS ✅
Code Review Summary
- Critical: 0 | High: 0 | Medium: 0 (fixed) | Low: 1
Changes Verified
resolveStage()routing: clear prompt → discover (was: plan) ✅StageProgressionmetadata added withbuildStageProgression()pure function ✅stageHintcaller override preserved (backward compat) ✅- Tests: routing updated, stageProgression 3개, staged default 3개 추가 ✅
Fixed in Review
- [MEDIUM] Unused
PlanningStagetype import removed (lint error)
Remaining (Low - acceptable)
- [LOW]
stageProgressiontyped as optional but always populated — acceptable for API evolution
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1420
Test plan