feat(mcp-server): preserve planning agent question-first guidance at standard verbosity (#1419)#1429
Merged
Merged
Conversation
JeremyDev87
added
feat
sub-issue
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…standard verbosity (#1419) Add planningContract field to IncludedAgent that survives all verbosity levels. Planning agents (technical-planner, solution-architect, plan-mode, auto-mode) in PLAN/AUTO modes receive core question-first rules regardless of whether systemPrompt is truncated to a summary. - Create pure planning-contract.ts module with resolvePlanningContract() - Add planningContract optional field to IncludedAgent interface - Wire into addIncludedAgentToResult after both full and standard paths - 14 unit tests covering mode/agent filtering and edge cases
JeremyDev87
force-pushed
the
feat/planning-contract-1419
branch
from
8d16bb3 to
bc80121
Compare
JeremyDev87
commented
Apr 7, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status: ALL PASS ✅
Code Review Summary
- Critical: 0 | High: 0 | Medium: 2 (non-blocking) | Low: 1
Changes Verified
planning-contract.ts— pure module,resolvePlanningContract()✅IncludedAgent.planningContract?: string[]— additive, backward-compat ✅keyword.service.ts— wired after both verbosity paths ✅- 14 unit tests — mode/agent combinations, edge cases ✅
Fixed in Review
- Prettier formatting on keyword.service.ts
Non-blocking Suggestions
- [MEDIUM] Consider moving
planning-contract.tstoshared/(cross-module import direction) - [MEDIUM] Add integration test in
keyword.service.spec.tsfor end-to-end verification - [LOW] agentId case-sensitivity asymmetry (currently all callers pass lowercase)
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planningContractfield toIncludedAgentthat survives all verbosity levelsplanning-contract.tsmodule withresolvePlanningContract()functionCloses #1419
Test plan
resolvePlanningContract()(mode/agent filtering) — 14 tests