feat(mcp/plugin): render a real opening council scene in Claude Code first responses (#1421)#1430
Merged
Merged
Conversation
…#1421) Add buildCouncilSceneInstructions() to generate rendering instructions from council scene metadata and inject into the instructions field for PLAN/EVAL/AUTO modes. ACT mode remains compact with no council scene. MCP changes: - New pure function buildCouncilSceneInstructions() in council-scene.builder.ts - Wired into mode.handler.ts to append council rendering block to instructions - 7 new unit tests + 3 integration tests Plugin changes: - Updated mode_engine.py build_instructions() with matching rendering format - 3 new test cases for face+name+role format, moderator copy, EVAL rendering
JeremyDev87
added
feat
sub-issue
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
commented
Apr 7, 2026
JeremyDev87
left a comment
JeremyDev87
left a comment
Owner
Author
There was a problem hiding this comment.
Review: APPROVE
CI Status: ALL PASS ✅
Code Review Summary
- Critical: 0 | High: 0 | Medium: 1 (non-blocking) | Low: 1
Changes Verified
buildCouncilSceneInstructions()pure function — returns rendering block or undefined ✅- MCP: wired into
result.instructionsfor PLAN/EVAL/AUTO, ACT excluded ✅ - Plugin: standalone parity with face+name+role format ✅
- Clarification override correctly replaces instructions (council scene discarded for ambiguous requests) ✅
- Tests: 7 unit + 3 integration (MCP) + 5 plugin tests ✅
Non-blocking Suggestions
- [MEDIUM] Consider local variable instead of
result.instructions +=to avoid mutation (style consistency with clarification gate) - [LOW] CHAR_LIMIT truncation edge case — current priority order is correct (template > council > enrichment)
Recommendation: APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildCouncilSceneInstructions()to generate rendering instructions from council scene metadatainstructionsfield for PLAN/EVAL/AUTO modesmode_engine.pywith matching rendering formatCloses #1421
Test plan
buildCouncilSceneInstructions()(7 tests: undefined/disabled/empty-cast/valid-scene/faces-names-roles/moderatorCopy/format)