fix: close Wow Wave sub-issue gaps (#1444 + build drift)#1461
Merged
Conversation
Wire RuleTracker write-path for self-evolving rule effectiveness (#1444): - Extend RuleStats with generatedRule / baselineFailureRate / currentFailureRate - Add markRuleAsGenerated(name) and recordFailureRate(name, rate, kind) APIs - Existing trackRuleUsage preserves the generatedRule flag across updates - Drop cast hack in RuleInsightsService now that fields are first-class - 7 new rule-tracker tests cover tagging, failure rate recording, and persistence Sync auto-generated plugin README with manual surface additions (#1218): - scripts/build.ts feature table now includes Staged planning, Clarification gate, Permission forecast, and Council scene rows - Footnote matches post-v5.4.0 wording ("features that read agent definitions") - Regenerated README.md bumps version 5.4.0 → 5.4.1 (aligning with package.json) Also closes already-implemented sub-issues found by the verification pass: #1442 (pipeline wiring), #1443 (suggest_rules handler), #1445 (prompt suggestions), #1446 (onboarding tour integration), #1447 (PreToolUse rule checker), #1448 (violation renderer).
JeremyDev87
added
bug
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat(mcp): add effectiveness scoring to rule impact report #1444 write-path wiring:
RuleInsightsService.computeEffectivenessScoresalready computed effectiveness for auto-generated rules, butRuleTrackernever storedgeneratedRule/baselineFailureRate/currentFailureRatefields. This PR adds first-class support:RuleStatswith optional fields so tracker and service share a single source of truthmarkRuleAsGenerated(name)andrecordFailureRate(name, rate, kind)tracker APIstrackRuleUsagepreserves thegeneratedRuleflag across subsequent usage updatesas unknown as RuleStatscast hack inrule-insights.service.tsand its specPlugin README build drift:
scripts/build.tsfeature table template did not include the Staged planning, Clarification gate, Permission forecast, and Council scene rows thatca16373added to the rendered README. Runningyarn buildsilently stripped them. This PR updates the template so the build regenerates the expected output, and also picks up the 5.4.0 → 5.4.1 version sync withpackage.json.Sub-issue cleanup: closed 6 sub-issues (feat(plugin): connect PatternDetector to RuleSuggester pipeline #1442, feat(mcp): add suggest_rules MCP tool for auto-generated rule proposals #1443, feat(plugin): enrich project scanner with actionable prompt suggestions #1445, feat(plugin): integrate project-specific suggestions into onboarding tour #1446, feat(plugin): PreToolUse rule violation checker for Edit/Write interception #1447, feat(plugin): guardrail violation report rendering with rule reference #1448) found to be already implemented during the verification pass, each with a commit-SHA reference.
Test plan
yarn workspace codingbuddy test rule-tracker rule-insights→ 52/52 passedyarn workspace codingbuddy lint→ 0 errors (1 preexisting warning)yarn workspace codingbuddy format:check→ all files formattedyarn workspace codingbuddy typecheck→ cleanyarn workspace codingbuddy test:coverage→ 6270 passed / 2 skippedyarn workspace codingbuddy circular→ no circular depsyarn workspace codingbuddy build→ bundle builtyarn workspace codingbuddy-claude-pluginlint / format / typecheck / test / circular / build → all pass (144 tests)yarn buildin plugin regenerates README.md/namespace-manifest.json deterministically; no drift remains on diskCloses #1444