Skip to content

Commit 3816898

Browse files
Fix obsolete Testcontainers API calls after 4.10.0 upgrade (#91)
* Initial plan * Plan to fix obsolete Testcontainers API calls Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> * Fix obsolete Testcontainers API calls Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
1 parent ee33bad commit 3816898

3 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/JD.Efcpt.Build.Tasks/packages.lock.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,15 @@
8484
"SQLitePCLRaw.core": "2.1.10"
8585
}
8686
},
87+
"Microsoft.NETFramework.ReferenceAssemblies": {
88+
"type": "Direct",
89+
"requested": "[1.0.3, )",
90+
"resolved": "1.0.3",
91+
"contentHash": "vUc9Npcs14QsyOD01tnv/m8sQUnGTGOw1BCmKcv77LBJY7OxhJ+zJF7UD/sCL3lYNFuqmQEVlkfS4Quif6FyYg==",
92+
"dependencies": {
93+
"Microsoft.NETFramework.ReferenceAssemblies.net472": "1.0.3"
94+
}
95+
},
8796
"MySqlConnector": {
8897
"type": "Direct",
8998
"requested": "[2.4.0, )",
@@ -495,6 +504,11 @@
495504
"System.Runtime.CompilerServices.Unsafe": "6.1.0"
496505
}
497506
},
507+
"Microsoft.NETFramework.ReferenceAssemblies.net472": {
508+
"type": "Transitive",
509+
"resolved": "1.0.3",
510+
"contentHash": "0E7evZXHXaDYYiLRfpyXvCh+yzM2rNTyuZDI+ZO7UUqSc6GfjePiXTdqJGtgIKUwdI81tzQKmaWprnUiPj9hAw=="
511+
},
498512
"Mono.Unix": {
499513
"type": "Transitive",
500514
"resolved": "7.1.0-final.1.21458.1",

tests/JD.Efcpt.Build.Tests/Integration/FirebirdSchemaIntegrationTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
3636

3737
private static async Task<TestContext> SetupEmptyDatabase()
3838
{
39-
var container = new FirebirdSqlBuilder()
40-
.WithImage("jacobalberty/firebird:v4.0")
39+
var container = new FirebirdSqlBuilder("jacobalberty/firebird:v4.0")
4140
.Build();
4241

4342
await container.StartAsync();

tests/JD.Efcpt.Build.Tests/Integration/SnowflakeSchemaIntegrationTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
5656
private static async Task<TestContext> SetupEmptyDatabase()
5757
{
5858
// LocalStack Snowflake uses port 4566 and requires auth token
59-
var container = new ContainerBuilder()
60-
.WithImage("localstack/snowflake:latest")
59+
var container = new ContainerBuilder("localstack/snowflake:latest")
6160
.WithPortBinding(4566, true)
6261
.WithEnvironment("LOCALSTACK_AUTH_TOKEN", LocalStackAuthToken!)
6362
.WithEnvironment("SF_DEFAULT_USER", "test")

0 commit comments

Comments
 (0)