Skip to content

Commit bd6b89d

Browse files
refactor: Remove redundant WithImage() calls in Testcontainers setup (#103)
* Initial plan * refactor: remove redundant WithImage() calls and outdated.txt Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
1 parent bae7bad commit bd6b89d

6 files changed

Lines changed: 19 additions & 188 deletions

File tree

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ samples/**/DatabaseProject/**/*.sql
2323
!samples/**/DatabaseProject/**/*.sqlproj
2424
!samples/**/DatabaseProject/**/*.csproj
2525
packages/
26+
27+
# CI-generated dependency reports
28+
outdated.txt

outdated.txt

Lines changed: 0 additions & 183 deletions
This file was deleted.

src/JD.Efcpt.Build.Tasks/packages.lock.json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,15 @@
8787
"SQLitePCLRaw.core": "2.1.10"
8888
}
8989
},
90+
"Microsoft.NETFramework.ReferenceAssemblies": {
91+
"type": "Direct",
92+
"requested": "[1.0.3, )",
93+
"resolved": "1.0.3",
94+
"contentHash": "vUc9Npcs14QsyOD01tnv/m8sQUnGTGOw1BCmKcv77LBJY7OxhJ+zJF7UD/sCL3lYNFuqmQEVlkfS4Quif6FyYg==",
95+
"dependencies": {
96+
"Microsoft.NETFramework.ReferenceAssemblies.net472": "1.0.3"
97+
}
98+
},
9099
"MySqlConnector": {
91100
"type": "Direct",
92101
"requested": "[2.5.0, )",
@@ -493,6 +502,11 @@
493502
"System.Runtime.CompilerServices.Unsafe": "6.1.0"
494503
}
495504
},
505+
"Microsoft.NETFramework.ReferenceAssemblies.net472": {
506+
"type": "Transitive",
507+
"resolved": "1.0.3",
508+
"contentHash": "0E7evZXHXaDYYiLRfpyXvCh+yzM2rNTyuZDI+ZO7UUqSc6GfjePiXTdqJGtgIKUwdI81tzQKmaWprnUiPj9hAw=="
509+
},
496510
"Mono.Unix": {
497511
"type": "Transitive",
498512
"resolved": "7.1.0-final.1.21458.1",

tests/JD.Efcpt.Build.Tests/Integration/MySqlSchemaIntegrationTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
3232
private static async Task<TestContext> SetupEmptyDatabase()
3333
{
3434
var container = new MySqlBuilder("mysql:8.0")
35-
.WithImage("mysql:8.0")
3635
.Build();
3736

3837
await container.StartAsync();

tests/JD.Efcpt.Build.Tests/Integration/OracleSchemaIntegrationTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
4040

4141
private static async Task<TestContext> SetupEmptyDatabase()
4242
{
43-
var container = new OracleBuilder("gvenzl/oracle-xe:21-slim-faststart")
44-
.WithImage("gvenzl/oracle-xe:21.3.0-slim-faststart")
43+
var container = new OracleBuilder("gvenzl/oracle-xe:21.3.0-slim-faststart")
4544
.Build();
4645

4746
await container.StartAsync();

tests/JD.Efcpt.Build.Tests/Integration/PostgreSqlSchemaIntegrationTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
3131

3232
private static async Task<TestContext> SetupEmptyDatabase()
3333
{
34-
var container = new PostgreSqlBuilder("postgres:16")
35-
.WithImage("postgres:16-alpine")
34+
var container = new PostgreSqlBuilder("postgres:16-alpine")
3635
.Build();
3736

3837
await container.StartAsync();

0 commit comments

Comments
 (0)