Support Import element with Sdk attribute in SqlProjectDetector#73
Merged
JerrettDavis merged 2 commits intomainfrom Jan 20, 2026
Merged
Support Import element with Sdk attribute in SqlProjectDetector#73JerrettDavis merged 2 commits intomainfrom
JerrettDavis merged 2 commits intomainfrom
Conversation
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SDK detection method for project types
Support Import element with Sdk attribute in SqlProjectDetector
Jan 20, 2026
Contributor
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 79.81% 87.79% +7.98%
==========================================
Files 61 61
Lines 3834 3843 +9
Branches 556 558 +2
==========================================
+ Hits 3060 3374 +314
+ Misses 550 469 -81
+ Partials 224 0 -224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerrettDavis
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SqlProjectDetectoronly recognized two of the three MSBuild SDK reference methods. The third method, using<Import>elements withSdkattributes, was not detected.Changes
HasSupportedSdk()to detect<Import Sdk="..." />elementsSupported SDK Reference Methods
All three MSBuild-documented methods now work:
The detector now parses SDK names from Import elements, handling versioned SDKs (
MSBuild.Sdk.SqlProj/3.0.0) and semicolon-delimited multi-SDK references.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
invalid/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/JD.Efcpt.Build/JD.Efcpt.Build/tests/JD.Efcpt.Build.Tests/bin/Release/net10.0/JD.Efcpt.Build.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/JD.Efcpt.Build/JD.Efcpt.Build/tests/JD.Efcpt.Build.Tests/bin/Release/net10.0/JD.Efcpt.Build.Tests.deps.json /home/REDACTED/work/JD.Efcpt.Build/JD.Efcpt.Build/tests/JD.Efcpt.Build.Tests/bin/Release/net10.0/testhost.dll --port 38777 --endpoint 127.0.0.1:038777 --role client --parentprocessid 4122 --telemetryoptedin false(dns block)learn.microsoft.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)www.example.com/opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) 702/log.json sh 92h ea59925589bc8be3/run/containerd/io.containerd.runtime.v2.task/moby/4c67f69d17dbab164cb60ab15c24bsh io.containerd.ru--log-format 0879f962a88a6ccdjson by/447066470f842mktemp 8c1e3937f58d4c9e82c7bc7f58cda6e1290/d05484a25ee0418c60f9f77e69707ce44cbb28b1902d6afb�� 000b7d90345b5b3c--process 33d/log.json(dns block)/opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) af029a7e269f05a7--root proxy ff91�� c601 601 b1388e8313cdec26a7a1a1e594d08a0e357/log.json 620 /usr/bin/containstart ff7321dbd6b0e40c2b06bac878ccc8832ba07977b49ea8c1e3937f58d4c9e82c7bc7f58cda6e1290 aunch_sqlservr.sh qlse�� /tmp/runc-shim.log(dns block)/opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) docker0(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.