Skip to content

Fix obsolete Testcontainers API calls after 4.10.0 upgrade #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerrettDavis merged 3 commits into from
Feb 10, 2026
Merged

Fix obsolete Testcontainers API calls after 4.10.0 upgrade #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d88d5e
Initial plan
Copilot Feb 10, 2026
222a0d9
Plan to fix obsolete Testcontainers API calls
Copilot Feb 10, 2026
334c535
Fix obsolete Testcontainers API calls
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/JD.Efcpt.Build.Tasks/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,15 @@
"SQLitePCLRaw.core": "2.1.10"
}
},
"Microsoft.NETFramework.ReferenceAssemblies": {
"type": "Direct",
"requested": "[1.0.3, )",
"resolved": "1.0.3",
"contentHash": "vUc9Npcs14QsyOD01tnv/m8sQUnGTGOw1BCmKcv77LBJY7OxhJ+zJF7UD/sCL3lYNFuqmQEVlkfS4Quif6FyYg==",
"dependencies": {
"Microsoft.NETFramework.ReferenceAssemblies.net472": "1.0.3"
}
},
"MySqlConnector": {
"type": "Direct",
"requested": "[2.4.0, )",
Expand Down Expand Up @@ -495,6 +504,11 @@
"System.Runtime.CompilerServices.Unsafe": "6.1.0"
}
},
"Microsoft.NETFramework.ReferenceAssemblies.net472": {
"type": "Transitive",
"resolved": "1.0.3",
"contentHash": "0E7evZXHXaDYYiLRfpyXvCh+yzM2rNTyuZDI+ZO7UUqSc6GfjePiXTdqJGtgIKUwdI81tzQKmaWprnUiPj9hAw=="
},
"Mono.Unix": {
"type": "Transitive",
"resolved": "7.1.0-final.1.21458.1",
Expand Down
3 changes: 1 addition & 2 deletions tests/JD.Efcpt.Build.Tests/Integration/FirebirdSchemaIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1

private static async Task<TestContext> SetupEmptyDatabase()
{
var container = new FirebirdSqlBuilder()
.WithImage("jacobalberty/firebird:v4.0")
var container = new FirebirdSqlBuilder("jacobalberty/firebird:v4.0")
.Build();

await container.StartAsync();
Expand Down
3 changes: 1 addition & 2 deletions tests/JD.Efcpt.Build.Tests/Integration/SnowflakeSchemaIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ private sealed record FingerprintResult(TestContext Context, string Fingerprint1
private static async Task<TestContext> SetupEmptyDatabase()
{
// LocalStack Snowflake uses port 4566 and requires auth token
var container = new ContainerBuilder()
.WithImage("localstack/snowflake:latest")
var container = new ContainerBuilder("localstack/snowflake:latest")
.WithPortBinding(4566, true)
.WithEnvironment("LOCALSTACK_AUTH_TOKEN", LocalStackAuthToken!)
.WithEnvironment("SF_DEFAULT_USER", "test")
Expand Down