Postgres, pass type casted binds for select queries

Author: JesseChavez

lib/arjdbc/abstract/database_statements.rb

@@ -44,14 +44,17 @@ def internal_exec_query(sql, name = nil, binds = NO_BINDS, prepare: false, async
 
         binds = convert_legacy_binds_to_attributes(binds) if binds.first.is_a?(Array)
 
+        # puts "internal----->sql: #{sql}, binds: #{binds}"
+        type_casted_binds = type_casted_binds(binds)
+
         with_raw_connection do |conn|
           if without_prepared_statement?(binds)
             log(sql, name, async: async) { conn.execute_query(sql) }
           else
-            log(sql, name, binds, async: async) do
+            log(sql, name, type_casted_binds, async: async) do
               # this is different from normal AR that always caches
               cached_statement = fetch_cached_statement(sql) if prepare && @jdbc_statement_cache_enabled
-              conn.execute_prepared_query(sql, binds, cached_statement)
+              conn.execute_prepared_query(sql, type_casted_binds, cached_statement)
             end
           end
         end

src/java/arjdbc/postgresql/PostgreSQLRubyJdbcConnection.java

@@ -691,7 +691,7 @@ protected void setStringParameter(final ThreadContext context,
             }
         }
 
-        super.setStringParameter(context, connection, statement, index, value, attribute, type);
+        statement.setObject(index, value.asString().toString(), Types.OTHER);
     }
 
 

test/simple.rb

@@ -890,6 +890,16 @@ def test_string_id
     assert_equal "some_string", f.id
   end
 
+  def test_time_bind_param
+    with_timezone_config default: :utc, zone: 'Australia/Melbourne' do
+      time = Time.zone.local(2000, 1, 1, 16)
+      entry = Entry.create!(updated_on: time + 1.hour)
+      sql = 'updated_on >= ?'
+      entries = Entry.where(sql, time)
+      assert_equal 1, entries.size
+    end
+  end
+
   def test_handles_quotes_inside_of_strings
     content_json = {
       "comments" => [