Skip to content

Commit 442bb6b

Browse files
committed
Use libs-fork.versions.toml
1 parent 2932b0b commit 442bb6b

3 files changed

Lines changed: 24 additions & 44 deletions

File tree

buildSrc-fork/private/src/main/kotlin/org/jetbrains/androidx/build/AndroidXForkTargetsExtensions.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package org.jetbrains.androidx.build
1919
import androidx.build.AndroidXMultiplatformExtension
2020
import androidx.build.PlatformIdentifier
2121
import androidx.build.configurePinnedKotlinLibraries
22+
import androidx.build.getVersionByName
2223
import androidx.build.multiplatformExtension
2324
import org.gradle.api.Action
2425
import org.gradle.api.Project
@@ -30,7 +31,6 @@ import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinNativeTargetWithSimulatorTes
3031
import org.jetbrains.kotlin.gradle.targets.js.dsl.KotlinJsTargetDsl
3132
import org.jetbrains.kotlin.gradle.targets.js.testing.KotlinJsTest
3233
import org.jetbrains.kotlin.konan.target.KonanTarget
33-
import org.tomlj.Toml
3434

3535
private fun KotlinJsTest.passTestFlagsToEnvironment() {
3636
listOf(
@@ -51,10 +51,7 @@ fun <T> AndroidXMultiplatformExtension.configureForkWebTarget(
5151
createTarget: (KotlinJsTargetDsl.() -> Unit) -> T,
5252
block: Action<KotlinJsTargetDsl>? = null,
5353
): T? {
54-
val toml = Toml.parse(
55-
project.rootProject.projectDir.resolve("gradle/libs.versions.toml").toPath()
56-
)
57-
val skikoVersion = toml.getTable("versions")!!.getString("skiko")!!
54+
val skikoVersion = project.getVersionByName("skiko")
5855
val skikoWasm = project.configurations.findByName("skikoWasm")
5956
?: project.configurations.create("skikoWasm")
6057

buildSrc/settings-fork.gradle

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,17 @@
1616

1717
rootProject.buildFileName = "../buildSrc-fork/build.gradle"
1818

19+
dependencyResolutionManagement {
20+
// the default libs.version.toml is automatically registered by Gradle under `libs` name.
21+
// to avoid the conflict with `libs-fork`, rename it
22+
defaultLibrariesExtensionName = "aospLibs"
23+
versionCatalogs {
24+
libs {
25+
from(files("../gradle/libs-fork.versions.toml"))
26+
}
27+
}
28+
}
29+
1930
def includeProject(String projectPath, String projectDir) {
2031
include projectPath
2132
project(projectPath).projectDir = new File(projectDir)
@@ -47,20 +58,3 @@ includeProject(":imports:inspection-gradle-plugin", "../buildSrc-fork/imports/in
4758
includeProject(":imports:room-gradle-plugin", "../buildSrc-fork/imports/room-gradle-plugin")
4859
includeProject(":imports:glance-layout-generator", "../buildSrc-fork/imports/glance-layout-generator")
4960
includeProject(":imports:stableaidl-gradle-plugin", "../buildSrc-fork/imports/stableaidl-gradle-plugin")
50-
51-
dependencyResolutionManagement {
52-
versionCatalogs {
53-
libs {
54-
def agpOverride = System.getenv("GRADLE_PLUGIN_VERSION")
55-
if (agpOverride != null) {
56-
logger.warn("Using custom version ${agpOverride} of AGP due to GRADLE_PLUGIN_VERSION being set.")
57-
version('androidGradlePlugin', agpOverride)
58-
}
59-
def lintOverride = System.getenv("LINT_VERSION")
60-
if (lintOverride != null) {
61-
logger.warn("Using custom version ${lintOverride} of Lint due to LINT_VERSION being set.")
62-
version('androidLint', lintOverride)
63-
}
64-
}
65-
}
66-
}

settings-fork.gradle

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,17 @@ rootProject.buildFileName = "build-fork.gradle"
44

55
enableFeaturePreview "STABLE_CONFIGURATION_CACHE"
66

7+
dependencyResolutionManagement {
8+
// the default libs.version.toml is automatically registered by Gradle under `libs` name.
9+
// to avoid the conflict with `libs-fork`, rename it
10+
defaultLibrariesExtensionName = "aospLibs"
11+
versionCatalogs {
12+
libs {
13+
from(files("gradle/libs-fork.versions.toml"))
14+
}
15+
}
16+
}
17+
718
def supportRootFolder = buildscript.sourceFile.getParentFile()
819
skikoSetup.defineSkikoInVersionCatalog(settings)
920

@@ -128,28 +139,6 @@ switch (cacheSetting) {
128139

129140
rootProject.name = "compose-multiplatform-core"
130141

131-
dependencyResolutionManagement {
132-
versionCatalogs {
133-
libs {
134-
def metalavaOverride = System.getenv("METALAVA_VERSION")
135-
if (metalavaOverride != null) {
136-
logger.warn("Using custom version ${metalavaOverride} of metalava due to METALAVA_VERSION being set.")
137-
version('metalava', metalavaOverride)
138-
}
139-
def agpOverride = System.getenv("GRADLE_PLUGIN_VERSION")
140-
if (agpOverride != null) {
141-
logger.warn("Using custom version ${agpOverride} of AGP due to GRADLE_PLUGIN_VERSION being set.")
142-
version('androidGradlePlugin', agpOverride)
143-
}
144-
def lintOverride = System.getenv("LINT_VERSION")
145-
if (lintOverride != null) {
146-
logger.warn("Using custom version ${lintOverride} of Lint due to LINT_VERSION being set.")
147-
version('androidLint', lintOverride)
148-
}
149-
}
150-
}
151-
}
152-
153142
/////////////////////////////
154143
//
155144
// Buildscript utils

0 commit comments

Comments
 (0)